[GitHub] [ozone] bshashikant commented on a change in pull request #1893: HDDS-4740. Admin command should take effect on all SCM instance

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #1893:
URL: https://github.com/apache/ozone/pull/1893#discussion_r570887514



##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMContainerLocationFailoverProxyProvider.java
##########
@@ -50,16 +51,17 @@
 import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_SERVICE_IDS_KEY;
 
 /**
- * Failover proxy provider for SCM container location.
+ * Failover proxy provider for StorageContainerLocationProtocolPB.
  */
 public class SCMContainerLocationFailoverProxyProvider implements
     FailoverProxyProvider<StorageContainerLocationProtocolPB>, Closeable {
   public static final Logger LOG =
       LoggerFactory.getLogger(SCMContainerLocationFailoverProxyProvider.class);
 
-  private Map<String, ProxyInfo<StorageContainerLocationProtocolPB>> scmProxies;
-  private Map<String, SCMProxyInfo> scmProxyInfoMap;
-  private List<String> scmNodeIDList;
+  private final Map<String,

Review comment:
       Can u please add some comments to describe what these maps should contain?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org