You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/04 05:34:21 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #12802: Compile static assets when running setup.py.
jhtimmins opened a new pull request #12802:
URL: https://github.com/apache/airflow/pull/12802
If Airflow is installed but static assets aren't compiled, the web UI will load but it won't work properly. One result is that CSRF tokens won't be added to POST requests, causing them to fail.
Addresses https://github.com/apache/airflow/issues/12262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738736936
> What we could do instead is to fail if the assets haven't been generated?
Assets are not required to run airflow scheduler or worker, so failing installation due to missing assets is rather not ok. Probably we may want to print information after installation that assets has to be compiled for webserver. Eventually we can compile them at webserver start if they are missing. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738581998
[The Workflow run](https://github.com/apache/airflow/actions/runs/400004735) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738738908
> Sorry, yes, I didn't sleep well. I meant "fail the `webserver` command"
Faillng webserver is indeed smth we should do. Also maybe a little more than that. We should fail the webserver when the assets are not generated using the current sources (need regeneration). This happened several times in breeze environment that people complained about not working webserver and the reason was that after James's improvements the old "compiled" assets were wrong and you needed to re-compile them,
This could be as easy as making hash of all the "sources" and storing it at compile time and comparing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738737276
Sorry, yes, I didn't sleep well. I meant "fail the `webserver` command"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #12802:
URL: https://github.com/apache/airflow/pull/12802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738738908
> Sorry, yes, I didn't sleep well. I meant "fail the `webserver` command"
Faillng webserver is indeed smth we should do. Also maybe a little more than that. We should fail the webserver when the assets are not generated using the current sources (need regeneration). This happened several times in breeze environment that people complained about not working webserver and the reason was that after james's improvements the old "compiled" assets were wrong and you needed to re-compile them,
This could be as easy as making hash of all the "sources" and storing it at compile time and comparing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738738908
> Sorry, yes, I didn't sleep well. I meant "fail the `webserver` command"
Faillng webserver is indeed smth we should do. Also maybe a little more than that. We should fail the webserver when the assets are not generated using the current sources (need regeneration). This happened several times in breeze environment that people complained about not working webserver and the reason was that after Ryan's improvements the old "compiled" assets were wrong and you needed to re-compile them,
This could be as easy as making hash of all the "sources" and storing it at compile time and comparing it when you start the webserver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738739920
@ryanahamilton Is there anyway webpack can do this for us?
Maybe in dev/"local checkout" it makes sense to just run webpack (but not compile_assets.sh as that nukes and rebuilds, so will take a long time) automatically?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738738908
> Sorry, yes, I didn't sleep well. I meant "fail the `webserver` command"
Faillng webserver is indeed smth we should do. Also maybe a little more than that. We should fail the webserver when the assets are not generated using the current sources (need regeneration). This happened several times in breeze environment that people complained about not working webserver and the reason was that after James's improvements the old "compiled" assets were wrong and you needed to re-compile them,
This could be as easy as making hash of all the "sources" and storing it at compile time and comparing it when you start the webserver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12802: Compile static assets when running setup.py.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12802:
URL: https://github.com/apache/airflow/pull/12802#issuecomment-738741656
> @ryanahamilton Is there anyway webpack can do this for us?
>
> Maybe in dev/"local checkout" it makes sense to just run webpack (but not compile_assets.sh as that nukes and rebuilds, so will take a long time) automatically?
Yeah. I bet there is a ready solution for that. We are not the first with the problem :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org