[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6808: [PQL Deprecation] Remove the usage of PQL compiler

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #6808:
URL: https://github.com/apache/incubator-pinot/pull/6808#issuecomment-822971024


   @fx19880617 
   
   > During the migration, one big change is that the reserved keywords are required to be double-quoted in SQL but not in PQL.
   
   The only change to the production code is the `InbuiltFunctionEvaluator` which should use the SQL parser, but is using the PQL parser currently. All other changes only migrate the tests to use the SQL parser so that we can clean up the PQL parser much easier.
   For PQL code path, we will still use the PQL compiler to parse the expression.
    
   > Can we have a test to ensure we give the user clear information/Error message that this keyword has to be double-quoted, e.g. `SELECT timestamp FROM myTable`?
   
   We already have tests for reserved words in `CalciteSqlCompilerTest.testReservedKeywords()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org