[GitHub] [orc] wgtmac commented on pull request #1455: ORC-1401: [C++] allow writing an intermediate footer

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on PR #1455:
URL: https://github.com/apache/orc/pull/1455#issuecomment-1507817301

   Some CI checks fail due to following reason, please use `static_cast` to fix those errors.
   
   ```
   /Users/runner/work/orc/orc/c++/src/Writer.cc:324:10: error: virtual function 'writeIntermediateFooter' has a different return type ('long') than the function it overrides (which has return type 'int64_t' (aka 'long long'))
       long writeIntermediateFooter() override;
       ~~~~ ^
   /Users/runner/work/orc/orc/c++/include/orc/Writer.hh:312:21: note: overridden virtual function is here
       virtual int64_t writeIntermediateFooter() = 0;
               ~~~~~~~ ^
   /Users/runner/work/orc/orc/c++/src/Writer.cc:418:36: error: implicit conversion changes signedness: 'uint64_t' (aka 'unsigned long long') to 'long' [-Werror,-Wsign-conversion]
         lastFlushOffset = outStream->getLength();
                         ~ ~~~~~~~~~~~^~~~~~~~~~~
   /Users/runner/work/orc/orc/c++/src/Writer.cc:419:23: error: implicit conversion changes signedness: 'long' to 'uint64_t' (aka 'unsigned long long') [-Werror,-Wsign-conversion]
         currentOffset = lastFlushOffset;
                       ~ ^~~~~~~~~~~~~~~
   3 errors generated.
   ```
   
   In addition, the C++ format check failures can be fixed by applying `clang-format`. @hinxx  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org