You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by fj...@apache.org on 2019/07/03 15:31:37 UTC
[incubator-druid] branch master updated: adjust PR template (#8016)
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 53a32b6 adjust PR template (#8016)
53a32b6 is described below
commit 53a32b6f55ba905d96f4dc8d389b0dd30cd95977
Author: Clint Wylie <cw...@apache.org>
AuthorDate: Wed Jul 3 08:31:31 2019 -0700
adjust PR template (#8016)
---
.github/pull_request_template.md | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 44d1c61..80b5e41 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -43,13 +43,10 @@ Some of the aspects mentioned above may be omitted for simple and small changes.
This PR has:
- [ ] been self-reviewed.
- - [ ] using the [concurrency checklist](
- https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR
- doesn't have any relation to concurrency.)
+ - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
-- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar
-reader.
+- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org