You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2009/07/07 09:56:14 UTC
[jira] Created: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
[classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
----------------------------------------------------------------------------------------------------------------------
Key: HARMONY-6260
URL: https://issues.apache.org/jira/browse/HARMONY-6260
Project: Harmony
Issue Type: Bug
Reporter: Li Jing Qin
Attachments: MyPipe.java, PipeTest.java
Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by Charles Lee <li...@gmail.com>.
I see. I will recreate the jira.
On Thu, Jul 9, 2009 at 5:39 PM, Tim Ellison <t....@gmail.com> wrote:
> On 09/Jul/2009 10:27, Charles Lee wrote:
> > On Thu, Jul 9, 2009 at 3:38 PM, Regis <xu...@gmail.com> wrote:
> >
> >> Charles Lee wrote:
> >>
> >>> It's a complicate situation. For example, user can override the read(),
> >>> which eats the exception thrown there. And this will make read(byte[],
> >>> int,
> >>> int) pass successful. Since PipedInputStream and PipedOutputStream are
> >>>
> >> He can override read(byte[], int, int) either. I'd like think it's a
> >> non-bug difference, and more, Harmony's implementation is better:
> reading
> >> batch data once is better than reading one by one byte.
> >>
> > I agree it's better to read data once. With the result of the test case,
> RI
> > seems to read one byte first to check the situation, and then read batch
> > data.
> > By the way, does harmony has a list about non-bug difference?
>
> Yes, create a JIRA and assign it to the component "Non-bug differences
> from RI"
>
> Regards,
> Tim
>
>
--
Yours sincerely,
Charles Lee
Re: [jira] Commented: (HARMONY-6260) [classlib][luni] RI's PipedInputStream.read(byte[],
int, int) using its PipedInputStream.read(), but harmony does not.
Posted by Tim Ellison <t....@gmail.com>.
On 09/Jul/2009 10:27, Charles Lee wrote:
> On Thu, Jul 9, 2009 at 3:38 PM, Regis <xu...@gmail.com> wrote:
>
>> Charles Lee wrote:
>>
>>> It's a complicate situation. For example, user can override the read(),
>>> which eats the exception thrown there. And this will make read(byte[],
>>> int,
>>> int) pass successful. Since PipedInputStream and PipedOutputStream are
>>>
>> He can override read(byte[], int, int) either. I'd like think it's a
>> non-bug difference, and more, Harmony's implementation is better: reading
>> batch data once is better than reading one by one byte.
>>
> I agree it's better to read data once. With the result of the test case, RI
> seems to read one byte first to check the situation, and then read batch
> data.
> By the way, does harmony has a list about non-bug difference?
Yes, create a JIRA and assign it to the component "Non-bug differences
from RI"
Regards,
Tim
Re: [jira] Commented: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by Charles Lee <li...@gmail.com>.
On Thu, Jul 9, 2009 at 3:38 PM, Regis <xu...@gmail.com> wrote:
> Charles Lee wrote:
>
>> It's a complicate situation. For example, user can override the read(),
>> which eats the exception thrown there. And this will make read(byte[],
>> int,
>> int) pass successful. Since PipedInputStream and PipedOutputStream are
>>
>
> He can override read(byte[], int, int) either. I'd like think it's a
> non-bug difference, and more, Harmony's implementation is better: reading
> batch data once is better than reading one by one byte.
>
I agree it's better to read data once. With the result of the test case, RI
seems to read one byte first to check the situation, and then read batch
data.
By the way, does harmony has a list about non-bug difference?
>
> related to the multi thread. User maybe need more control to these
>> operation.
>>
>> On Tue, Jul 7, 2009 at 4:00 PM, Regis Xu (JIRA) <ji...@apache.org> wrote:
>>
>> [
>>>
>>> https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727975#action_12727975
>>> ]
>>>
>>> Regis Xu commented on HARMONY-6260:
>>> -----------------------------------
>>>
>>> I'm not clear why this implementation specific behaviors cause ant fails?
>>>
>>> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its
>>>>
>>> PipedInputStream.read(), but harmony does not.
>>>
>>> ----------------------------------------------------------------------------------------------------------------------
>>>
>>>> Key: HARMONY-6260
>>>> URL: https://issues.apache.org/jira/browse/HARMONY-6260
>>>> Project: Harmony
>>>> Issue Type: Bug
>>>> Reporter: Li Jing Qin
>>>> Attachments: MyPipe.java, PipeTest.java
>>>>
>>>>
>>>> Do some test cases which attached by this issue. We can easily found
>>>> that
>>>>
>>> PipedInputStream.read(byte[], int, int) using its own read() method. But
>>> harmony does not. This causes ant fails. May cause other applications
>>> fail.
>>>
>>>> Any comments?
>>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>>
>>
>>
>
> --
> Best Regards,
> Regis.
>
--
Yours sincerely,
Charles Lee
Re: [jira] Commented: (HARMONY-6260) [classlib][luni] RI's PipedInputStream.read(byte[],
int, int) using its PipedInputStream.read(), but harmony does not.
Posted by Regis <xu...@gmail.com>.
Charles Lee wrote:
> It's a complicate situation. For example, user can override the read(),
> which eats the exception thrown there. And this will make read(byte[], int,
> int) pass successful. Since PipedInputStream and PipedOutputStream are
He can override read(byte[], int, int) either. I'd like think it's a non-bug
difference, and more, Harmony's implementation is better: reading batch data
once is better than reading one by one byte.
> related to the multi thread. User maybe need more control to these
> operation.
>
> On Tue, Jul 7, 2009 at 4:00 PM, Regis Xu (JIRA) <ji...@apache.org> wrote:
>
>> [
>> https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727975#action_12727975]
>>
>> Regis Xu commented on HARMONY-6260:
>> -----------------------------------
>>
>> I'm not clear why this implementation specific behaviors cause ant fails?
>>
>>> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its
>> PipedInputStream.read(), but harmony does not.
>> ----------------------------------------------------------------------------------------------------------------------
>>> Key: HARMONY-6260
>>> URL: https://issues.apache.org/jira/browse/HARMONY-6260
>>> Project: Harmony
>>> Issue Type: Bug
>>> Reporter: Li Jing Qin
>>> Attachments: MyPipe.java, PipeTest.java
>>>
>>>
>>> Do some test cases which attached by this issue. We can easily found that
>> PipedInputStream.read(byte[], int, int) using its own read() method. But
>> harmony does not. This causes ant fails. May cause other applications fail.
>>> Any comments?
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
--
Best Regards,
Regis.
Re: [jira] Commented: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by Charles Lee <li...@gmail.com>.
It's a complicate situation. For example, user can override the read(),
which eats the exception thrown there. And this will make read(byte[], int,
int) pass successful. Since PipedInputStream and PipedOutputStream are
related to the multi thread. User maybe need more control to these
operation.
On Tue, Jul 7, 2009 at 4:00 PM, Regis Xu (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727975#action_12727975]
>
> Regis Xu commented on HARMONY-6260:
> -----------------------------------
>
> I'm not clear why this implementation specific behaviors cause ant fails?
>
> > [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its
> PipedInputStream.read(), but harmony does not.
> >
> ----------------------------------------------------------------------------------------------------------------------
> >
> > Key: HARMONY-6260
> > URL: https://issues.apache.org/jira/browse/HARMONY-6260
> > Project: Harmony
> > Issue Type: Bug
> > Reporter: Li Jing Qin
> > Attachments: MyPipe.java, PipeTest.java
> >
> >
> > Do some test cases which attached by this issue. We can easily found that
> PipedInputStream.read(byte[], int, int) using its own read() method. But
> harmony does not. This causes ant fails. May cause other applications fail.
> > Any comments?
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Yours sincerely,
Charles Lee
[jira] Commented: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730347#action_12730347 ]
Tim Ellison commented on HARMONY-6260:
--------------------------------------
Li Jing the patch does not apply cleanly for me. Please could you refresh it and attach an updated version.
Thanks.
> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6260
> URL: https://issues.apache.org/jira/browse/HARMONY-6260
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Reporter: Li Jing Qin
> Attachments: HARMONY-6260.diff, MyPipe.java, PipeTest.java
>
>
> Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
> Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6260:
---------------------------------
Attachment: HARMONY-6260.diff.v2
Sorry for the late reply. Here is the refresh patch.
> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6260
> URL: https://issues.apache.org/jira/browse/HARMONY-6260
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Reporter: Li Jing Qin
> Attachments: HARMONY-6260.diff, HARMONY-6260.diff.v2, MyPipe.java, PipeTest.java
>
>
> Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
> Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6260:
---------------------------------
Attachment: MyPipe.java
PipeTest.java
This is the small test files which we can find that read(byte[],int,int) using read()
> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6260
> URL: https://issues.apache.org/jira/browse/HARMONY-6260
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Attachments: MyPipe.java, PipeTest.java
>
>
> Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
> Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-6260:
-------------------------------------
Component/s: Classlib
> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6260
> URL: https://issues.apache.org/jira/browse/HARMONY-6260
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Li Jing Qin
> Attachments: MyPipe.java, PipeTest.java
>
>
> Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
> Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727975#action_12727975 ]
Regis Xu commented on HARMONY-6260:
-----------------------------------
I'm not clear why this implementation specific behaviors cause ant fails?
> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6260
> URL: https://issues.apache.org/jira/browse/HARMONY-6260
> Project: Harmony
> Issue Type: Bug
> Reporter: Li Jing Qin
> Attachments: MyPipe.java, PipeTest.java
>
>
> Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
> Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6260:
---------------------------------
Component/s: (was: Classlib)
Non-bug differences from RI
Patch Info: [Patch Available]
> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6260
> URL: https://issues.apache.org/jira/browse/HARMONY-6260
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Reporter: Li Jing Qin
> Attachments: MyPipe.java, PipeTest.java
>
>
> Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
> Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6260) [classlib][luni] RI's
PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(),
but harmony does not.
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6260:
---------------------------------
Attachment: HARMONY-6260.diff
Though this is a non-bug difference, I'd like to apply the patch for this. Because this patch + HARMONY-6259 can make ant Redirector behavor correctly. Would anyone please to review it?
> [classlib][luni] RI's PipedInputStream.read(byte[], int, int) using its PipedInputStream.read(), but harmony does not.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-6260
> URL: https://issues.apache.org/jira/browse/HARMONY-6260
> Project: Harmony
> Issue Type: Bug
> Components: Non-bug differences from RI
> Reporter: Li Jing Qin
> Attachments: HARMONY-6260.diff, MyPipe.java, PipeTest.java
>
>
> Do some test cases which attached by this issue. We can easily found that PipedInputStream.read(byte[], int, int) using its own read() method. But harmony does not. This causes ant fails. May cause other applications fail.
> Any comments?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.