You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2023/08/31 15:09:37 UTC
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20444
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
IMPALA-12414: Add scripts to run Trino in the dev environment
This patch set adds a couple of scripts that makes it easy to run
Trino in the dev environment.
At first one need to build our custom Trino docker image via:
testdata/bin/build-trino-docker-image.sh
Then we can run the Trino container via:
testdata/bin/run-trino.sh
One can connect to the Trino CLI by:
testdata/bin/trino-cli.sh
Trino will be configured to access our HMS and HDFS. We add the
'hive' and 'iceberg' catalogs for Trino. Legacy Hive tables can
be accessed via the 'hive' catalog, while Iceberg tables (only the
ones reside in HiveCatalog) can be accessed via the 'iceberg'
catalog. E.g.:
trino> use iceberg.functional_parquet;
trino:functional_parquet> select count(*)
from iceberg_mixed_file_format;
_col0
-------
3
(1 row)
Testing
* no tests added
* later we might always run Trino as part of the minicluster and
add interop tests with it
Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
---
A testdata/bin/build-trino-docker-image.sh
A testdata/bin/kill-trino.sh
A testdata/bin/minicluster_trino/Dockerfile
A testdata/bin/minicluster_trino/hive.properties
A testdata/bin/minicluster_trino/iceberg.properties
A testdata/bin/run-trino.sh
A testdata/bin/trino-cli.sh
7 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/20444/1
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13895/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:39:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Sep 2023 17:43:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13909/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Sep 2023 08:21:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Sep 2023 19:56:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9713/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Sep 2023 17:43:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
IMPALA-12414: Add scripts to run Trino in the dev environment
This patch set adds a couple of scripts that makes it easy to run
Trino in the dev environment.
At first one need to build our custom Trino docker image via:
testdata/bin/build-trino-docker-image.sh
Then we can run the Trino container via:
testdata/bin/run-trino.sh
One can connect to the Trino CLI by:
testdata/bin/trino-cli.sh
Trino will be configured to access our HMS and HDFS. We add the
'hive' and 'iceberg' catalogs for Trino. Legacy Hive tables can
be accessed via the 'hive' catalog, while Iceberg tables (only the
ones reside in HiveCatalog) can be accessed via the 'iceberg'
catalog. E.g.:
trino> use iceberg.functional_parquet;
trino:functional_parquet> select count(*)
from iceberg_mixed_file_format;
_col0
-------
3
(1 row)
Testing
* no tests added
* later we might always run Trino as part of the minicluster and
add interop tests with it
Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Reviewed-on: http://gerrit.cloudera.org:8080/20444
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A testdata/bin/build-trino-docker-image.sh
A testdata/bin/kill-trino.sh
A testdata/bin/minicluster_trino/Dockerfile
A testdata/bin/minicluster_trino/hive.properties
A testdata/bin/minicluster_trino/iceberg.properties
A testdata/bin/run-trino.sh
A testdata/bin/trino-cli.sh
7 files changed, 162 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20444
to look at the new patch set (#4).
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
IMPALA-12414: Add scripts to run Trino in the dev environment
This patch set adds a couple of scripts that makes it easy to run
Trino in the dev environment.
At first one need to build our custom Trino docker image via:
testdata/bin/build-trino-docker-image.sh
Then we can run the Trino container via:
testdata/bin/run-trino.sh
One can connect to the Trino CLI by:
testdata/bin/trino-cli.sh
Trino will be configured to access our HMS and HDFS. We add the
'hive' and 'iceberg' catalogs for Trino. Legacy Hive tables can
be accessed via the 'hive' catalog, while Iceberg tables (only the
ones reside in HiveCatalog) can be accessed via the 'iceberg'
catalog. E.g.:
trino> use iceberg.functional_parquet;
trino:functional_parquet> select count(*)
from iceberg_mixed_file_format;
_col0
-------
3
(1 row)
Testing
* no tests added
* later we might always run Trino as part of the minicluster and
add interop tests with it
Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
---
A testdata/bin/build-trino-docker-image.sh
A testdata/bin/kill-trino.sh
A testdata/bin/minicluster_trino/Dockerfile
A testdata/bin/minicluster_trino/hive.properties
A testdata/bin/minicluster_trino/iceberg.properties
A testdata/bin/run-trino.sh
A testdata/bin/trino-cli.sh
7 files changed, 162 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/20444/4
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13913/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Sep 2023 12:26:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "John Sherman (Code Review)" <ge...@cloudera.org>.
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
my nit is optional imo
http://gerrit.cloudera.org:8080/#/c/20444/1/testdata/bin/minicluster_trino/hive.properties
File testdata/bin/minicluster_trino/hive.properties:
http://gerrit.cloudera.org:8080/#/c/20444/1/testdata/bin/minicluster_trino/hive.properties@4
PS1, Line 4:
very small nit: empty new line at the end of the file
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:31:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20444
to look at the new patch set (#3).
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
IMPALA-12414: Add scripts to run Trino in the dev environment
This patch set adds a couple of scripts that makes it easy to run
Trino in the dev environment.
At first one need to build our custom Trino docker image via:
testdata/bin/build-trino-docker-image.sh
Then we can run the Trino container via:
testdata/bin/run-trino.sh
One can connect to the Trino CLI by:
testdata/bin/trino-cli.sh
Trino will be configured to access our HMS and HDFS. We add the
'hive' and 'iceberg' catalogs for Trino. Legacy Hive tables can
be accessed via the 'hive' catalog, while Iceberg tables (only the
ones reside in HiveCatalog) can be accessed via the 'iceberg'
catalog. E.g.:
trino> use iceberg.functional_parquet;
trino:functional_parquet> select count(*)
from iceberg_mixed_file_format;
_col0
-------
3
(1 row)
Testing
* no tests added
* later we might always run Trino as part of the minicluster and
add interop tests with it
Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
---
A testdata/bin/build-trino-docker-image.sh
A testdata/bin/kill-trino.sh
A testdata/bin/minicluster_trino/Dockerfile
A testdata/bin/minicluster_trino/hive.properties
A testdata/bin/minicluster_trino/iceberg.properties
A testdata/bin/run-trino.sh
A testdata/bin/trino-cli.sh
7 files changed, 171 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/20444/3
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 2:
(1 comment)
Thanks for the comments. I also fixed the RAT issue.
http://gerrit.cloudera.org:8080/#/c/20444/1/testdata/bin/minicluster_trino/hive.properties
File testdata/bin/minicluster_trino/hive.properties:
http://gerrit.cloudera.org:8080/#/c/20444/1/testdata/bin/minicluster_trino/hive.properties@4
PS1, Line 4: # regarding copyright ownership. The ASF licenses this file
> very small nit: empty new line at the end of the file
Done
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:53:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 4: Code-Review+1
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Sep 2023 08:49:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Impala Public Jenkins, John Sherman,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20444
to look at the new patch set (#2).
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
IMPALA-12414: Add scripts to run Trino in the dev environment
This patch set adds a couple of scripts that makes it easy to run
Trino in the dev environment.
At first one need to build our custom Trino docker image via:
testdata/bin/build-trino-docker-image.sh
Then we can run the Trino container via:
testdata/bin/run-trino.sh
One can connect to the Trino CLI by:
testdata/bin/trino-cli.sh
Trino will be configured to access our HMS and HDFS. We add the
'hive' and 'iceberg' catalogs for Trino. Legacy Hive tables can
be accessed via the 'hive' catalog, while Iceberg tables (only the
ones reside in HiveCatalog) can be accessed via the 'iceberg'
catalog. E.g.:
trino> use iceberg.functional_parquet;
trino:functional_parquet> select count(*)
from iceberg_mixed_file_format;
_col0
-------
3
(1 row)
Testing
* no tests added
* later we might always run Trino as part of the minicluster and
add interop tests with it
Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
---
A testdata/bin/build-trino-docker-image.sh
A testdata/bin/kill-trino.sh
A testdata/bin/minicluster_trino/Dockerfile
A testdata/bin/minicluster_trino/hive.properties
A testdata/bin/minicluster_trino/iceberg.properties
A testdata/bin/run-trino.sh
A testdata/bin/trino-cli.sh
7 files changed, 174 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/20444/2
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13897/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 16:18:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12414: Add scripts to run Trino in the dev environment
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20444 )
Change subject: IMPALA-12414: Add scripts to run Trino in the dev environment
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49818c7a95e23988b3fbc3d31b4c7fa738e0d952
Gerrit-Change-Number: 20444
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Sep 2023 22:07:12 +0000
Gerrit-HasComments: No