You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/08/14 23:01:27 UTC
Re: Review Request 24714: fix prefiex glog on mac
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/
-----------------------------------------------------------
(Updated Aug. 14, 2014, 9:01 p.m.)
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Fixes on glog check to support mac.
Diffs
-----
3rdparty/libprocess/configure.ac f552e60
configure.ac 30a7e26
Diff: https://reviews.apache.org/r/24714/diff/
Testing
-------
./configure --with-glog=/opt/local && make check
Thanks,
Timothy St. Clair
Re: Review Request 24714: fix prefiex glog on mac
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote:
> > configure.ac, line 281
> > <https://reviews.apache.org/r/24714/diff/1/?file=660837#file660837line281>
> >
> > so "src" worked on linux but not on osx? how's that possible?
>
> Timothy St. Clair wrote:
> It shouldn't have worked.
> It likely flew under the radar due to system installation.
https://reviews.apache.org/r/23453/diff/#
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
-----------------------------------------------------------
On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 9:01 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes on glog check to support mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60
> configure.ac 30a7e26
>
> Diff: https://reviews.apache.org/r/24714/diff/
>
>
> Testing
> -------
>
> ./configure --with-glog=/opt/local && make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 24714: fix prefiex glog on mac
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote:
> > configure.ac, line 281
> > <https://reviews.apache.org/r/24714/diff/1/?file=660837#file660837line281>
> >
> > so "src" worked on linux but not on osx? how's that possible?
It shouldn't have worked.
It likely flew under the radar due to system installation.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
-----------------------------------------------------------
On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 9:01 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes on glog check to support mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60
> configure.ac 30a7e26
>
> Diff: https://reviews.apache.org/r/24714/diff/
>
>
> Testing
> -------
>
> ./configure --with-glog=/opt/local && make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 24714: fix prefiex glog on mac
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
-----------------------------------------------------------
configure.ac
<https://reviews.apache.org/r/24714/#comment88496>
so "src" worked on linux but not on osx? how's that possible?
- Vinod Kone
On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 9:01 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes on glog check to support mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60
> configure.ac 30a7e26
>
> Diff: https://reviews.apache.org/r/24714/diff/
>
>
> Testing
> -------
>
> ./configure --with-glog=/opt/local && make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 24714: fix prefiex glog on mac
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50642
-----------------------------------------------------------
Ship it!
pls test this on linux too if you haven't already, before committing.
- Vinod Kone
On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 9:01 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes on glog check to support mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60
> configure.ac 30a7e26
>
> Diff: https://reviews.apache.org/r/24714/diff/
>
>
> Testing
> -------
>
> ./configure --with-glog=/opt/local && make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 24714: fix prefix glog on mac
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On Aug. 15, 2014, 8:33 a.m., Mesos ReviewBot wrote:
> > Patch looks great!
> >
> > Reviews applied: [24714]
> >
> > All tests passed.
contained in: https://reviews.apache.org/r/24734/
Lets close this one out.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50712
-----------------------------------------------------------
On Aug. 15, 2014, 1:07 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 1:07 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes on glog check to support mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60
> configure.ac 30a7e26
>
> Diff: https://reviews.apache.org/r/24714/diff/
>
>
> Testing
> -------
>
> ./configure --with-glog=/opt/local && make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 24714: fix prefix glog on mac
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50712
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24714]
All tests passed.
- Mesos ReviewBot
On Aug. 15, 2014, 1:07 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24714/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 1:07 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixes on glog check to support mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f552e60
> configure.ac 30a7e26
>
> Diff: https://reviews.apache.org/r/24714/diff/
>
>
> Testing
> -------
>
> ./configure --with-glog=/opt/local && make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 24714: fix prefix glog on mac
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 1:07 a.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
fix prefix glog on mac
Repository: mesos-git
Description
-------
Fixes on glog check to support mac.
Diffs
-----
3rdparty/libprocess/configure.ac f552e60
configure.ac 30a7e26
Diff: https://reviews.apache.org/r/24714/diff/
Testing
-------
./configure --with-glog=/opt/local && make check
Thanks,
Timothy St. Clair