[GitHub] [doris] Kikyou1997 commented on a diff in pull request #18502: [ehancement](stats) Stats preheating as FE booted

["Kikyou1997 (via GitHub)" <gi...@apache.org>]

Kikyou1997 commented on code in PR #18502:
URL: https://github.com/apache/doris/pull/18502#discussion_r1161507643


##########
fe/fe-core/src/test/java/org/apache/doris/nereids/jobs/cascades/DeriveStatsJobTest.java:
##########
@@ -70,7 +70,7 @@ public void testExecute() throws Exception {
         }
         Statistics statistics = cascadesContext.getMemo().getRoot().getStatistics();
         Assertions.assertNotNull(statistics);
-        Assertions.assertTrue(Precision.equals(0.5, statistics.getRowCount(), 0.1));
+        Assertions.assertTrue(Precision.equals(0, statistics.getRowCount(), 0.1));

Review Comment:
   Remove some useless codes in unit tests, those codes is hard to maintaince and it's not a good idea for testing the accurracy of stats estimation according to the advise from @englefly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org