You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/01 22:22:00 UTC
[jira] [Work logged] (BEAM-13051) Enable all practical pylint warnings
[ https://issues.apache.org/jira/browse/BEAM-13051?focusedWorklogId=734995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734995 ]
ASF GitHub Bot logged work on BEAM-13051:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 22:21
Start Date: 01/Mar/22 22:21
Worklog Time Spent: 10m
Work Description: roger-mike commented on pull request #16562:
URL: https://github.com/apache/beam/pull/16562#issuecomment-1055917356
Run PythonLint PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 734995)
Time Spent: 28h 10m (was: 28h)
> Enable all practical pylint warnings
> ------------------------------------
>
> Key: BEAM-13051
> URL: https://issues.apache.org/jira/browse/BEAM-13051
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P2
> Time Spent: 28h 10m
> Remaining Estimate: 0h
>
> We currently have 75 pylint checks disabled globally: https://github.com/apache/beam/blob/0863d95205410567a7ab191fd0a46308a0d54bb7/sdks/python/.pylintrc#L81
> I think some of these are impractical for Beam (e.g. [super-init-not-called|https://pycodequ.al/docs/pylint-messages/w0231-super-init-not-called.html] because of BEAM-6158), but most of them are verifying good conventions that we should try to stick to. Let's enable as many of the checks as possible, such that the only disabled checks are really impractical for Beam, or are incompatible with the Beam community's coding style.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)