[GitHub] [trafficserver] ywkaras commented on a change in pull request #7584: Call constructors and destructors for H1/2 Session/Transaction via ClassAllocator

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #7584:
URL: https://github.com/apache/trafficserver/pull/7584#discussion_r590527249



##########
File path: proxy/http2/Http2SessionAccept.cc
##########
@@ -54,9 +54,8 @@ Http2SessionAccept::accept(NetVConnection *netvc, MIOBuffer *iobuf, IOBufferRead
   }
 
   Http2ClientSession *new_session = THREAD_ALLOC_INIT(http2ClientSessionAllocator, this_ethread());
-  new (new_session) Http2ClientSession();
-  new_session->acl            = std::move(session_acl);
-  new_session->accept_options = &options;
+  new_session->acl                = std::move(session_acl);
+  new_session->accept_options     = &options;

Review comment:
       Why the extra spaces?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org