You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 09:23:59 UTC
[GitHub] [apisix-dashboard] starsz opened a new pull request #1123: fix: fix some sleep location in e2e test
starsz opened a new pull request #1123:
URL: https://github.com/apache/apisix-dashboard/pull/1123
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bugfix
- Description
Some sleep location isn't correct. We should add `sleep` if the request method is GET.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1123: fix: fix some sleep location in e2e test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1123:
URL: https://github.com/apache/apisix-dashboard/pull/1123#issuecomment-751218950
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=desc) (b5c8691) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/02a4702f53105f95eecc175f08d7bfb9de3ef6b2?el=desc) (02a4702) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1123/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
+ Coverage 41.80% 41.86% +0.05%
==========================================
Files 29 29
Lines 1825 1825
==========================================
+ Hits 763 764 +1
+ Misses 954 953 -1
Partials 108 108
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1123/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.12% <0.00%> (+0.62%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=footer). Last update [02a4702...b5c8691](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1123: fix: fix some sleep location in e2e test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1123:
URL: https://github.com/apache/apisix-dashboard/pull/1123#issuecomment-751218950
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=h1) Report
> Merging [#1123](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=desc) (5ca7ffb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e0af89e7df02de137aeac3d4bad53cf2efde41c6?el=desc) (e0af89e) will **increase** coverage by `0.19%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1123/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
+ Coverage 41.67% 41.86% +0.19%
==========================================
Files 29 29
Lines 1819 1825 +6
==========================================
+ Hits 758 764 +6
- Misses 952 953 +1
+ Partials 109 108 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1123/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1123/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1123/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.12% <0.00%> (+1.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=footer). Last update [e0af89e...5ca7ffb](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #1123: fix: fix some sleep location in e2e test
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #1123:
URL: https://github.com/apache/apisix-dashboard/pull/1123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org