You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/03/30 05:48:10 UTC

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3670: [WIP] Optimize write step by skipping convert to 3 steps

VenuReddy2103 commented on a change in pull request #3670: [WIP] Optimize write step by skipping convert to 3 steps
URL: https://github.com/apache/carbondata/pull/3670#discussion_r399940162
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java
 ##########
 @@ -192,6 +196,16 @@ public SortStepRowHandler(SortParameters sortParameters) {
     return out;
   }
 
+  public Object[] convertToFlatRow(IntermediateSortTempRow sortTempRow) {
+    List<Object> out = new ArrayList<>();
 
 Review comment:
   Suggest to create with initialCapacity as the number of elements are at this point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services