[jira] Commented: (OFBIZ-2329) Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice

["Pranay Pandey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701378#action_12701378 ] 

Pranay Pandey commented on OFBIZ-2329:
--------------------------------------

Thanks Akash for providing patch.
I reviewed, tested this patch. Functionality is proper. Only those orders are being worked on Packing screen which have been verified from Verify Pick screen.
Few things in the patch I found which can be improved are:
1. Following ui label should is not neede.
{code}
<property key="OrderNotFound">
    <value xml:lang="en">Order #${orderId} cannot be found</value>
</property>

You can use existing one 

<property key="OrderErrorOrderIdNotFound">
    <value xml:lang="en">ERROR: Order with ID [${orderId}] not found</value>
</property>
{code}

2.
{code}
<property key="NoShipGroupSequenceIdCannotProcess">
    <value xml:lang="en">No ship group sequence ID. Cannot process</value>
</property>

To

<property key="NoShipGroupSequenceIdFoundCannotProcess">
    <value xml:lang="en">No ship group sequence Id found can not process</value>
</property>
{code}

Also most of the ui labels are good candidate to moved on to OrderErrorUiLabels.xml.

3. In groovy you don't need to do this:
{code}UtilMisc.toMap("orderId", orderId){code}

4. I think you forgot to make a change in PackOrder.groovy here:
{code}request.setAttribute("errorMessageList", ['No ship group sequence ID. Cannot process.']);{code}

5. There are places in groovy and ftl where after adding new condition you have not reformatted the whole code inside that block and I think its a good idea because only those changes are visible which should be. Once a patch with these improvements is committed you can provide a patch which will only contain the reformatted code.

> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2329
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2329
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice. 
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.