You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2025/02/01 03:06:04 UTC

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

frankvicky commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1938174948


##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##########
@@ -2265,4 +2267,17 @@ public ByteBuffer buffer() {
             return data;
         }
     }
+
+    private boolean isSupport853(RaftProtocol raftProtocol) {

Review Comment:
   Thanks.
   I don't notice that we have such a helper method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org