[GitHub] [arrow-rs] nevi-me commented on issue #2502: Inline Generated Thift Code Into Parquet Crate

[GitBox <gi...@apache.org>]

nevi-me commented on issue #2502:
URL: https://github.com/apache/arrow-rs/issues/2502#issuecomment-1220351915

   > It's necessarily an incomplete picture, but looking at the [reverse dependencies](https://crates.io/crates/parquet-format/reverse_dependencies) of parquet-format they all already have a dependency on `parquet`. As such I would like to propose inlining the generated code in a `format` module within `parquet`. This would avoid maintenance burden associated with an additional crate
   
   We've had this discussion before, and I support this approach (https://github.com/sunchao/parquet-format-rs/issues/10).
   
   I think what could also bolster the argument for making `parquet::format` is that in reality we (I) haven't seen people depend on a specific version of `parquet-format`. So whatever the latest version we support, should be authoritative. In the sense that it'd be lower maintenance if we generate the thrift code whenever there's a change (which is very infrequent), and expose that as part of `parquet`.
   
   @sunchao @tustvold I'd be in favour of deprecating and eventually archiving `parquet-format-rs`, then generating the code here. `thrift-rs` has come a long way since the early days, so it should be easier for external users to build their own format file if they don't want to depend on `parquet::format`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org