You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/29 00:24:55 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
tooptoop4 opened a new pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944
…ption
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
+ Coverage 84.52% 84.69% +0.16%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32591 32662 +71
+ Misses 5965 5904 -61
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.28% <0%> (+1.17%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.75% <0%> (+6.32%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <0%> (+7.04%)` | :arrow_up: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `88% <0%> (+32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#discussion_r363016598
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -377,6 +377,9 @@ update_fab_perms = True
# 0 means never get forcibly logged out
force_log_out_after = 0
+# 'Recent Tasks' stats will show for old DagRuns if True
Review comment:
see https://github.com/apache/airflow/pull/7037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32659 32662 +3
- Misses 5897 5904 +7
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
+ Coverage 84.52% 84.69% +0.16%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32591 32662 +71
+ Misses 5965 5904 -61
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.28% <0%> (+1.17%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.75% <0%> (+6.32%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <0%> (+7.04%)` | :arrow_up: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `88% <0%> (+32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
+ Coverage 84.52% 84.69% +0.16%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32591 32662 +71
+ Misses 5965 5904 -61
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.28% <0%> (+1.17%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.75% <0%> (+6.32%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <0%> (+7.04%)` | :arrow_up: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `88% <0%> (+32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
+ Coverage 84.52% 84.69% +0.16%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32591 32662 +71
+ Misses 5965 5904 -61
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.28% <0%> (+1.17%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.75% <0%> (+6.32%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <0%> (+7.04%)` | :arrow_up: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `88% <0%> (+32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-570757416
superseded by https://github.com/apache/airflow/pull/7037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
+ Coverage 84.52% 84.69% +0.16%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32591 32662 +71
+ Misses 5965 5904 -61
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.28% <0%> (+1.17%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.75% <0%> (+6.32%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <0%> (+7.04%)` | :arrow_up: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `88% <0%> (+32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#discussion_r362188834
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -377,6 +377,9 @@ update_fab_perms = True
# 0 means never get forcibly logged out
force_log_out_after = 0
+# 'Recent Tasks' stats will show for old DagRuns if True
Review comment:
Hi. Can you add some documentation? We do not yet have a document describing the configuration options of the webserver. Would you like to create it? If not, that's fine and you can also create a new document in the howto directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569493832
@drsantos20 i couldn't see a test for original task_stats functionality, as this change is guarded by opt-in config then no impact for existing users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
+ Coverage 84.52% 84.69% +0.16%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32591 32662 +71
+ Misses 5965 5904 -61
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.28% <0%> (+1.17%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.75% <0%> (+6.32%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <0%> (+7.04%)` | :arrow_up: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `88% <0%> (+32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> Merging [#6944](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `62.5%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
==========================================
+ Coverage 84.52% 84.69% +0.16%
==========================================
Files 680 680
Lines 38556 38566 +10
==========================================
+ Hits 32591 32662 +71
+ Misses 5965 5904 -61
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.63% <62.5%> (-0.46%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.28% <0%> (+1.17%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `88% <0%> (+2.66%)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.75% <0%> (+6.32%)` | :arrow_up: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `96.61% <0%> (+6.77%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <0%> (+7.04%)` | :arrow_up: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `88% <0%> (+32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [7d97d16...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569529523
@tooptoop4 -> Still the tests are targeting the "future" rather than the past.
We often cherry-pick some changes to 1.10 now + we want to make sure that we can refactor Airflow in the future without having to run tests manually, so we are now fairly strict in requiring tests for new functionalities - even if there were missing tests in the past. If you want to add new functionality, we expect you add tests, sorry :(.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#discussion_r362188834
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -377,6 +377,9 @@ update_fab_perms = True
# 0 means never get forcibly logged out
force_log_out_after = 0
+# 'Recent Tasks' stats will show for old DagRuns if True
Review comment:
Hi. Can you add some documentation? We do not yet have a document describing the configuration options of the webserver. Would you like to create it? If not, that's fine and you can also create a new document in the howto catalog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 closed pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
tooptoop4 closed pull request #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6944: [AIRFLOW-6360] 'Recent tasks' stats only show non-completed dagruns o…
URL: https://github.com/apache/airflow/pull/6944#issuecomment-569467137
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@b3c46a1`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `81.98%`.
[](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6944 +/- ##
=========================================
Coverage ? 84.69%
=========================================
Files ? 680
Lines ? 38566
Branches ? 0
=========================================
Hits ? 32662
Misses ? 5904
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==) | `0% <ø> (ø)` | |
| [airflow/cli/commands/rotate\_fernet\_key\_command.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvcm90YXRlX2Zlcm5ldF9rZXlfY29tbWFuZC5weQ==) | `0% <0%> (ø)` | |
| [airflow/contrib/auth/backends/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMva2VyYmVyb3NfYXV0aC5weQ==) | `0% <0%> (ø)` | |
| [airflow/contrib/auth/backends/password\_auth.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvcGFzc3dvcmRfYXV0aC5weQ==) | `0% <0%> (ø)` | |
| [airflow/contrib/auth/backends/ldap\_auth.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvbGRhcF9hdXRoLnB5) | `0% <0%> (ø)` | |
| [...ow/contrib/auth/backends/github\_enterprise\_auth.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ2l0aHViX2VudGVycHJpc2VfYXV0aC5weQ==) | `0% <0%> (ø)` | |
| [airflow/contrib/auth/backends/google\_auth.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2F1dGgvYmFja2VuZHMvZ29vZ2xlX2F1dGgucHk=) | `0% <0%> (ø)` | |
| [airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5) | `92.19% <100%> (ø)` | |
| [airflow/gcp/hooks/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfc3FsLnB5) | `65.94% <100%> (ø)` | |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.08% <100%> (ø)` | |
| ... and [57 more](https://codecov.io/gh/apache/airflow/pull/6944/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=footer). Last update [b3c46a1...126977d](https://codecov.io/gh/apache/airflow/pull/6944?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services