You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2016/03/11 10:53:12 UTC
[1/2] lucene-solr git commit: test bug: close the right reader (the
one we passed to newSearcher)
Repository: lucene-solr
Updated Branches:
refs/heads/master 343d9c6fa -> af3499384
test bug: close the right reader (the one we passed to newSearcher)
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/1a233d83
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/1a233d83
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/1a233d83
Branch: refs/heads/master
Commit: 1a233d83dedecc2cf3d807079e413dae6758fa74
Parents: 343d9c6
Author: Mike McCandless <mi...@apache.org>
Authored: Fri Mar 11 04:53:43 2016 -0500
Committer: Mike McCandless <mi...@apache.org>
Committed: Fri Mar 11 04:53:43 2016 -0500
----------------------------------------------------------------------
.../src/test/org/apache/lucene/queries/CommonTermsQueryTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/1a233d83/lucene/queries/src/test/org/apache/lucene/queries/CommonTermsQueryTest.java
----------------------------------------------------------------------
diff --git a/lucene/queries/src/test/org/apache/lucene/queries/CommonTermsQueryTest.java b/lucene/queries/src/test/org/apache/lucene/queries/CommonTermsQueryTest.java
index e991b0c..fa74497 100644
--- a/lucene/queries/src/test/org/apache/lucene/queries/CommonTermsQueryTest.java
+++ b/lucene/queries/src/test/org/apache/lucene/queries/CommonTermsQueryTest.java
@@ -489,7 +489,7 @@ public class CommonTermsQueryTest extends LuceneTestCase {
QueryUtils.check(random(), cq, newSearcher(reader2));
reader2.close();
} finally {
- IOUtils.close(wrapper, w, dir, analyzer);
+ IOUtils.close(reader, w, dir, analyzer);
}
}
[2/2] lucene-solr git commit: remove TODO that was in fact done
Posted by mi...@apache.org.
remove TODO that was in fact done
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/af349938
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/af349938
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/af349938
Branch: refs/heads/master
Commit: af3499384305e3651c40203495262d27e1eec9bb
Parents: 1a233d8
Author: Mike McCandless <mi...@apache.org>
Authored: Fri Mar 11 04:54:01 2016 -0500
Committer: Mike McCandless <mi...@apache.org>
Committed: Fri Mar 11 04:54:01 2016 -0500
----------------------------------------------------------------------
lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java | 3 ---
1 file changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/af349938/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java b/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
index 5388bb3..aa7e5dc 100644
--- a/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
+++ b/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
@@ -1059,9 +1059,6 @@ public class BKDWriter implements Closeable {
assert count > 0: "nodeID=" + nodeID + " leafNodeOffset=" + leafNodeOffset;
writeLeafBlockDocs(out, heapSource.docIDs, Math.toIntExact(source.start), count);
- // TODO: we should delta compress / only write suffix bytes, like terms dict (the values will all be "close together" since we are at
- // a leaf cell):
-
// First pass: find the per-dim common prefix for all values in this block:
Arrays.fill(commonPrefixLengths, bytesPerDim);
for (int i=0;i<count;i++) {