You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/08/31 15:07:53 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #37497: MINOR: fix cuda crossbow build
zeroshade opened a new pull request, #37497:
URL: https://github.com/apache/arrow/pull/37497
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
#37365 was built locally using a newer version of the CUDA driver API than the crossbow builds run with causing the crossbow build to fail due to a change in macro names. This puts the macro name back to allow it to build with the older version of the cuda driver api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701379234
@github-actions crossbow submit \*cuda\*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701783283
Revision: 4e6835b46f17f32d33d0099a731cc90104a556e7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b39bc0bebc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b39bc0bebc)
|Task|Status|
|----|------|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6042448301/job/16397574982)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701262333
Revision: 6626ee691d98860e6abb6fec951e79772d062963
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ccf9bbe515](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ccf9bbe515)
|Task|Status|
|----|------|
|conda-linux-aarch64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387807151)|
|conda-linux-ppc64le-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387802128)|
|conda-linux-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387803120)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387804138)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6039357034/job/16387810381)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6039357763/job/16387812707)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701782275
It seems that this has many changes to say "MINOR".
https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes
Could you open an issue for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: GH-37523: [C++][CI][CUDA] Don't use newer API and add missing CUDA dependencies
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1706738987
Revision: f204bab47afd9ec6128b46c7a4373ba3f7f6b27f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-00d8e7b991](https://github.com/ursacomputing/crossbow/branches/all?query=actions-00d8e7b991)
|Task|Status|
|----|------|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6086034154/job/16511464955)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701384737
Revision: 65d8df87dcd6ffb778618a036bc8855d3a95679a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f74ba67795](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f74ba67795)
|Task|Status|
|----|------|
|conda-linux-aarch64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16389930784)|
|conda-linux-ppc64le-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16389924747)|
|conda-linux-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16389928989)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16389931976)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6040010230/job/16389932079)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6040008021/job/16389924980)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1703073143
@kou thanks! Your cmake changes fixed it perfectly! also I agree completely that this has expanded beyond the scope of a MINOR change. I'll create an issue for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: GH-37523: [C++][CI][CUDA] Don't use newer API and add missing CUDA dependencies
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1706734187
@github-actions crossbow submit test-cuda-python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701262136
Revision: 6626ee691d98860e6abb6fec951e79772d062963
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b539647434](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b539647434)
|Task|Status|
|----|------|
|conda-linux-aarch64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387811015)|
|conda-linux-ppc64le-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387807706)|
|conda-linux-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387803048)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/16387808961)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/6039353607/job/16387798330)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6039353780/job/16387798912)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701779291
@github-actions crossbow submit test-cuda-python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #37497: GH-37523: [C++][CI][CUDA] Don't use newer API and add missing CUDA dependencies
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #37497:
URL: https://github.com/apache/arrow/pull/37497#discussion_r1313580913
##########
ci/scripts/python_build.sh:
##########
@@ -70,6 +70,7 @@ export PYARROW_WITH_SUBSTRAIT=${ARROW_SUBSTRAIT:-OFF}
export PYARROW_PARALLEL=${n_jobs}
export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH}
+export CMAKE_PREFIX_PATH=${ARROW_HOME}:${CMAKE_PREFIX_PATH}
Review Comment:
Do we need this?
If we don't need this, I want to revert this before we merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701233195
```
Unable to match any tasks for `ubuntu-cuda-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/6039155877
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701256962
@github-actions crossbow submit *cuda*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: GH-37523: [C++][CI][CUDA] fix cuda crossbow build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1703077890
:warning: GitHub issue #37523 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701230958
@github-actions crossbow submit ubuntu-cuda-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #37497: GH-37523: [C++][CI][CUDA] Don't use newer API and add missing CUDA dependencies
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #37497:
URL: https://github.com/apache/arrow/pull/37497#discussion_r1315947133
##########
ci/scripts/python_build.sh:
##########
@@ -70,6 +70,7 @@ export PYARROW_WITH_SUBSTRAIT=${ARROW_SUBSTRAIT:-OFF}
export PYARROW_PARALLEL=${n_jobs}
export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH}
+export CMAKE_PREFIX_PATH=${ARROW_HOME}:${CMAKE_PREFIX_PATH}
Review Comment:
that fixed one of the build errors, but I haven't tried without it since adding your fix. I'll try removing it and re-run the crossbow build, if all works fine then we're good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37497: GH-37523: [C++][CI][CUDA] Don't use newer API and add missing CUDA dependencies
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1709381888
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 13f0cd8ee44833efbced05c8505de12f9f02f235.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/16567078206) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1701808559
@pitrou @AlenkaF @jorisvandenbossche I haven't been able to work out why the include path for `cuda.h` isn't getting included properly for the pyarrow python build here. The change I made caused the `cuda.h` include to now be exposed to the cython build (previously it was only in a `.cc` file on the C++ side so the cython build never needed to include it through `cuda_api.h`). Unfortunately it seems i'm not familiar enough with the cython/pyarrow build to work this out on my own.
Running tests myself locally I don't have any problems building it with a mamba environment, so I'm not sure what I'm missing. Any of you have any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1703019820
@github-actions crossbow submit test-cuda-python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1703022701
Revision: 78ccfb9e7f6743a1b4b75d346e6aca54033f0bbf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0ca7a3d49d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0ca7a3d49d)
|Task|Status|
|----|------|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6051870184/job/16424207520)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1702167653
First thing I would try is adding the header file in the install of the cmake
https://github.com/apache/arrow/blob/c0998b1c94260284a624da6b3ddee6b59e5c4558/cpp/src/arrow/gpu/CMakeLists.txt#L84
as it is not being installed currently (https://github.com/ursacomputing/crossbow/actions/runs/6042448301/job/16397574982#step:5:6699).
I think this has to be updated here https://github.com/apache/arrow/blob/c0998b1c94260284a624da6b3ddee6b59e5c4558/cpp/src/arrow/gpu/CMakeLists.txt#L45 or here:
https://github.com/apache/arrow/blob/c0998b1c94260284a624da6b3ddee6b59e5c4558/cpp/src/arrow/gpu/CMakeLists.txt#L81-L84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37497: MINOR: fix cuda crossbow build
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37497:
URL: https://github.com/apache/arrow/pull/37497#issuecomment-1702186355
How about this?
```diff
diff --git a/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in b/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in
index bb36abf24..626c536a0 100644
--- a/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in
+++ b/cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in
@@ -30,6 +30,10 @@ include(CMakeFindDependencyMacro)
find_dependency(Arrow)
if(CMAKE_VERSION VERSION_LESS 3.17)
find_package(CUDA REQUIRED)
+ add_library(ArrowCUDA::cuda_driver SHARED IMPORTED)
+ set_target_properties(ArrowCUDA::cuda_driver
+ PROPERTIES IMPORTED_LOCATION "${CUDA_CUDA_LIBRARY}"
+ INTERFACE_INCLUDE_DIRECTORIES "${CUDA_INCLUDE_DIRS}")
else()
find_package(CUDAToolkit REQUIRED)
endif()
diff --git a/cpp/src/arrow/gpu/CMakeLists.txt b/cpp/src/arrow/gpu/CMakeLists.txt
index 2556f30f0..a5b176793 100644
--- a/cpp/src/arrow/gpu/CMakeLists.txt
+++ b/cpp/src/arrow/gpu/CMakeLists.txt
@@ -32,8 +32,11 @@ endif()
set(ARROW_CUDA_LINK_LIBS arrow::flatbuffers)
if(CMAKE_VERSION VERSION_LESS 3.17)
find_package(CUDA REQUIRED)
- set(ARROW_CUDA_SHARED_LINK_LIBS ${CUDA_CUDA_LIBRARY})
- include_directories(SYSTEM ${CUDA_INCLUDE_DIRS})
+ add_library(ArrowCUDA::cuda_driver SHARED IMPORTED)
+ set_target_properties(ArrowCUDA::cuda_driver
+ PROPERTIES IMPORTED_LOCATION "${CUDA_CUDA_LIBRARY}"
+ INTERFACE_INCLUDE_DIRECTORIES "${CUDA_INCLUDE_DIRS}")
+ set(ARROW_CUDA_SHARED_LINK_LIBS ArrowCUDA::cuda_driver)
else()
# find_package(CUDA) is deprecated, and for newer CUDA, it doesn't
# recognize that the CUDA driver library is in the "stubs" dir, but
@@ -61,6 +64,7 @@ add_arrow_lib(arrow_cuda
${ARROW_CUDA_SHARED_LINK_LIBS}
SHARED_INSTALL_INTERFACE_LIBS
Arrow::arrow_shared
+ ${ARROW_CUDA_SHARED_LINK_LIBS}
# Static arrow_cuda must also link against CUDA shared libs
STATIC_LINK_LIBS
${ARROW_CUDA_LINK_LIBS}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #37497: GH-37523: [C++][CI][CUDA] Don't use newer API and add missing CUDA dependencies
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #37497:
URL: https://github.com/apache/arrow/pull/37497#discussion_r1316072877
##########
ci/scripts/python_build.sh:
##########
@@ -70,6 +70,7 @@ export PYARROW_WITH_SUBSTRAIT=${ARROW_SUBSTRAIT:-OFF}
export PYARROW_PARALLEL=${n_jobs}
export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH}
+export CMAKE_PREFIX_PATH=${ARROW_HOME}:${CMAKE_PREFIX_PATH}
Review Comment:
looks good with it reverted! all is passing. Thanks for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #37497: GH-37523: [C++][CI][CUDA] Don't use newer API and add missing CUDA dependencies
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #37497:
URL: https://github.com/apache/arrow/pull/37497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org