You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by at...@apache.org on 2008/08/29 11:55:48 UTC
svn commit: r690168 -
/portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/PermissionManagerImpl.java
Author: ate
Date: Fri Aug 29 02:55:47 2008
New Revision: 690168
URL: http://svn.apache.org/viewvc?rev=690168&view=rev
Log:
Some TODO comments added for broken functionality I discovered.
These will have to be fixed shortly, but as the PermissionManager (and the whole of the security API) is going to be changed anyway, for now the TODO comments will do.
Modified:
portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/PermissionManagerImpl.java
Modified: portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/PermissionManagerImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/PermissionManagerImpl.java?rev=690168&r1=690167&r2=690168&view=diff
==============================================================================
--- portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/PermissionManagerImpl.java (original)
+++ portals/jetspeed-2/portal/branches/JS2-869/components/jetspeed-security/src/main/java/org/apache/jetspeed/security/impl/PermissionManagerImpl.java Fri Aug 29 02:55:47 2008
@@ -94,7 +94,10 @@
{
permissionsMap = new HashMap<String, HashSet<Permission>>();
permissionsCache.set(permissionsMap);
- }
+ }
+ // TODO Ate: broken!
+ // principal.getName() is not a valid key replacement here for old getFullPath():
+ // this needs to include the JetspeedPrincipal.getType() or its ClassName
HashSet<Permission> principalPermissions = permissionsMap.get(principal.getName());
if ( principalPermissions == null )
{
@@ -134,7 +137,9 @@
permissionsCache.set(permissionsMap);
}
Iterator<Principal> iter = principals.iterator();
- HashSet<Permission> principalPermissions;
+ HashSet<Permission> principalPermissions;
+
+ // TODO Ate: the following seems to be rather broken...
while (iter.hasNext())
for (Principal p : principals)
{
@@ -163,6 +168,9 @@
{
principalPermissions = new HashSet<Permission>();
}
+ // TODO Ate: broken!
+ // principal.getName() is not a valid key replacement here for old getFullPath():
+ // this needs to include the JetspeedPrincipal.getType() or its ClassName
permissionsMap.put(internalPrincipal.getName(), principalPermissions);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org