You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "sandeep-krishnamurthy (GitHub)" <gi...@apache.org> on 2018/08/23 20:53:18 UTC
[GitHub] [incubator-mxnet] sandeep-krishnamurthy opened pull request
#12315: Enable gluon multi worker data loader test
## Description ##
Re-enable the skipped test for Gluon DataLoader. Described in this issue - https://github.com/apache/incubator-mxnet/issues/11455
Tests are working fine on latest master.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [X] Changes are complete (i.e. I finished coding on this PR)
- [X] All changes have test coverage:
### Changes ###
- Enable - `tests/python/unittest/test_gluon_data.py:test_multi_worker`
## Comments ##
Ran for 10,000 runs on CPU/GPU with/without MKLDNN.
```
~/incubator-mxnet$ MXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/unittest/test_gluon_data.py:test_multi_worker
/usr/local/lib/python3.5/dist-packages/nose/util.py:453: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead
inspect.getargspec(func)
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=1359342575 to reproduce.
test_gluon_data.test_multi_worker ... ok
----------------------------------------------------------------------
Ran 1 test in 509.370s
OK
```
@marcoabreu
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12315 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue
#12315: Enable gluon multi worker data loader test
Posted by "sandeep-krishnamurthy (GitHub)" <gi...@apache.org>.
@marcoabreu - I would like to merge this change. As mentioned before, there are no failures in my trail runs. I would revert back / fix if any issues crop up.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12315 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue
#12315: Enable gluon multi worker data loader test
Posted by "sandeep-krishnamurthy (GitHub)" <gi...@apache.org>.
@piiswrong @marcoabreu - ping.
Can we merge this and see if any issues crop up? In my test runs, I didn't see any failures.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12315 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue
#12315: Enable gluon multi worker data loader test
Posted by "sandeep-krishnamurthy (GitHub)" <gi...@apache.org>.
@haojin2 - Can you please take a look? Thanks.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12315 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on issue #12315:
Enable gluon multi worker data loader test
Posted by "marcoabreu (GitHub)" <gi...@apache.org>.
@piiswrong disable the test. We should check back with him
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12315 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu closed pull request #12315:
Enable gluon multi worker data loader test
Posted by "marcoabreu (GitHub)" <gi...@apache.org>.
[ pull request closed by marcoabreu ]
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12315 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue
#12315: Enable gluon multi worker data loader test
Posted by "sandeep-krishnamurthy (GitHub)" <gi...@apache.org>.
@marcoabreu - ping.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12315 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org