[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11330: [OSPP] PHP E2E

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #11330:
URL: https://github.com/apache/skywalking/pull/11330#discussion_r1339480855


##########
test/e2e-v2/cases/php/expected/trace-info-detail.yml:
##########
@@ -15,30 +15,34 @@
 
 spans:
   {{- contains .spans }}
-  - traceid: {{ .traceid }}
-    segmentid: {{ .segmentid }}
+  - traceid: "{{ .traceid }}"
+    segmentid: "{{ .segmentid }}"
     spanid: {{ .spanid }}
     parentspanid: {{ .parentspanid }}
     refs: []
     servicecode: php
     serviceinstancename: {{ notEmpty .serviceinstancename }}
     starttime: {{ gt .starttime 0 }}
     endtime: {{ gt .endtime 0 }}
-    endpointname: /php/info
+    endpointname: POST:/php/info
     type: Entry
-    peer: {{ notEmpty .peer }}
+    peer: ""
     component: PHP
     iserror: false
     layer: Http
     tags:
       {{- contains .tags }}
       - key: url
         value: {{ notEmpty .value }}
+      - key: http.method
+        value: {{ notEmpty .value }}
+      - key: http.status_code
+        value: {{ notEmpty .value }}

Review Comment:
   @kezhenxu94 Any suggestion here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org