You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2011/08/29 21:47:49 UTC
svn commit: r1162961 - in /myfaces/html5/trunk:
myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/behavior/
myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/
myfaces-html5-core/src/main/java/org/apache/myfaces...
Author: lu4242
Date: Mon Aug 29 19:47:48 2011
New Revision: 1162961
URL: http://svn.apache.org/viewvc?rev=1162961&view=rev
Log:
MFHTML5-14 MyFaces HTML5 should be jdk 1.5 compatible
Modified:
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/behavior/DropTargetBehaviorRenderer.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputColorRenderer.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputDateTimeRenderer.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlInputTextRendererDelegate.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlTextInputSuggestionRendererHelper.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5EmailConverter.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/media/AbstractMediaRenderer.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java
myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/validator/DateTimeRangeValidator.java
myfaces/html5/trunk/myfaces-html5-demo/pom.xml
myfaces/html5/trunk/myfaces-html5-demo/src/main/java/org/apache/myfaces/html5/demo/bean/DndBean.java
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/behavior/DropTargetBehaviorRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/behavior/DropTargetBehaviorRenderer.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/behavior/DropTargetBehaviorRenderer.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/behavior/DropTargetBehaviorRenderer.java Mon Aug 29 19:47:48 2011
@@ -106,13 +106,13 @@ public class DropTargetBehaviorRenderer
// get value of param set in fx:dragSource
String param = requestParameterMap.get(MYFACES_HTML5_DND_PARAM_MIME_TYPE);
- if (param == null || param.isEmpty())
+ if (param == null || param.length() == 0)
param = null;
// get other data values with accepted mime types
Map<String, String> dropDataMap = null;
String strReceivedDataMimeTypes = requestParameterMap.get(MYFACES_DND_FOUND_MIME_TYPES_KEY);
- if (strReceivedDataMimeTypes != null && !strReceivedDataMimeTypes.isEmpty())
+ if (strReceivedDataMimeTypes != null && strReceivedDataMimeTypes.length() > 0)
{
dropDataMap = new HashMap<String, String>();
@@ -126,7 +126,7 @@ public class DropTargetBehaviorRenderer
continue;
String data = requestParameterMap.get(mimeType);
- if (data != null && !data.isEmpty())
+ if (data != null && data.length() > 0)
{
dropDataMap.put(mimeType, data);
}
@@ -236,7 +236,7 @@ public class DropTargetBehaviorRenderer
private void _checkAction(String action)
{
- if (action == null || action.isEmpty())
+ if (action == null || action.length() == 0)
return;
if (ALLOWED_ACTIONS.contains(action))
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputColorRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputColorRenderer.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputColorRenderer.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputColorRenderer.java Mon Aug 29 19:47:48 2011
@@ -124,7 +124,7 @@ class ColorConverter implements Converte
public Object getAsObject(FacesContext context, UIComponent uiComponent, String value) throws ConverterException
{
- if (value == null || value.toString().isEmpty())
+ if (value == null || value.toString().length() == 0)
{
return null;
}
@@ -140,7 +140,7 @@ class ColorConverter implements Converte
else
{
String invalidColorMessage = component.getInvalidColorMessage();
- if (invalidColorMessage != null && !invalidColorMessage.isEmpty())
+ if (invalidColorMessage != null && invalidColorMessage.length() > 0)
{
throw new ConverterException(new FacesMessage(FacesMessage.SEVERITY_ERROR, invalidColorMessage,
invalidColorMessage));
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputDateTimeRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputDateTimeRenderer.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputDateTimeRenderer.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputDateTimeRenderer.java Mon Aug 29 19:47:48 2011
@@ -233,7 +233,7 @@ public class HtmlInputDateTimeRenderer e
String type = component.getType();
if (log.isLoggable(Level.FINE))
log.fine("initial type is: " + type);
- if (type == null || type.isEmpty())
+ if (type == null || type.length() == 0)
{ // if not set, set default value.
if (log.isLoggable(Level.FINE))
log.fine("setting default type " + JsfProperties.INPUTDATETIME_TYPE_DATETIME);
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/HtmlInputTextRenderer.java Mon Aug 29 19:47:48 2011
@@ -168,7 +168,7 @@ public class HtmlInputTextRenderer exten
if (log.isLoggable(Level.FINE))
log.fine("type is :" + type);
- if (type == null || type.isEmpty())
+ if (type == null || type.length() == 0)
{
// set type to textarea, if no type is set and rows are set
if (component.getRows() > HtmlInputText.ROWS_DEFAULT_VALUE)
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlInputTextRendererDelegate.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlInputTextRendererDelegate.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlInputTextRendererDelegate.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlInputTextRendererDelegate.java Mon Aug 29 19:47:48 2011
@@ -94,7 +94,7 @@ public class HtmlInputTextRendererDelega
String type = component.getType();
if (log.isLoggable(Level.FINE))
log.fine("initial type is: " + type);
- if (type == null || type.isEmpty())
+ if (type == null || type.length() == 0)
{ // if not set, set default value.
if (log.isLoggable(Level.FINE))
log.fine("setting default type " + HTML5.INPUT_TYPE_TEXT);
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlTextInputSuggestionRendererHelper.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlTextInputSuggestionRendererHelper.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlTextInputSuggestionRendererHelper.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/delegate/HtmlTextInputSuggestionRendererHelper.java Mon Aug 29 19:47:48 2011
@@ -72,7 +72,7 @@ public class HtmlTextInputSuggestionRend
* attribute) should not be used
*/
String idOfDatalist = component.getDataList();
- if (idOfDatalist != null && !idOfDatalist.isEmpty() && shouldGenerateDatalist(component))
+ if (idOfDatalist != null && idOfDatalist.length() > 0 && shouldGenerateDatalist(component))
{
// WIKI: put a wiki page about this error
throw new FacesException(
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5DateTimeFormatUtils.java Mon Aug 29 19:47:48 2011
@@ -44,7 +44,7 @@ public class Html5DateTimeFormatUtils
*/
public static Date parseDateTime(String value, String type) throws ParseException
{
- if (value == null || value.isEmpty())
+ if (value == null || value.length() == 0)
return null;
if (HTML5.INPUT_TYPE_DATETIME.equals(type))
@@ -150,7 +150,7 @@ public class Html5DateTimeFormatUtils
// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#valid-global-date-and-time-string
private static Date _parseGlobalDateTime(String value) throws ParseException
{
- if (value == null || value.isEmpty())
+ if (value == null || value.length() == 0)
return null;
boolean utcDateTime = value.charAt(value.length() - 1) == 'Z';
@@ -212,7 +212,7 @@ public class Html5DateTimeFormatUtils
// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#valid-local-date-and-time-string
private static Date _parseLocalDateTime(String value) throws ParseException
{
- if (value == null || value.isEmpty())
+ if (value == null || value.length() == 0)
return null;
boolean hasMillis = value.indexOf('.') != -1;
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5EmailConverter.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5EmailConverter.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5EmailConverter.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/input/util/Html5EmailConverter.java Mon Aug 29 19:47:48 2011
@@ -42,7 +42,7 @@ public class Html5EmailConverter impleme
if (value == null)
return null;
- if (value.isEmpty())
+ if (value.length() == 0)
return null;
String[] emails = value.split(",");
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/media/AbstractMediaRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/media/AbstractMediaRenderer.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/media/AbstractMediaRenderer.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/media/AbstractMediaRenderer.java Mon Aug 29 19:47:48 2011
@@ -75,7 +75,7 @@ public abstract class AbstractMediaRende
String src = RendererUtils.getStringValue(facesContext, component);
if (log.isLoggable(Level.FINE))
log.fine("writing src '" + src + "'");
- if (src != null && !src.isEmpty())
+ if (src != null && src.length() > 0)
writer.writeAttribute(HTML5.SRC_ATTR, src, "value");
// no need to check the value of preload, it is bypassed anyway.
@@ -160,7 +160,7 @@ public abstract class AbstractMediaRende
writer.startElement(HTML5.SOURCE_ELEM, null);
// src is reqired to be present and not empty!
- if (mediaInfo.getSrc() == null || mediaInfo.getSrc().isEmpty())
+ if (mediaInfo.getSrc() == null || mediaInfo.getSrc().length() == 0)
// WIKI: add a wiki page
throw new FacesException("'src' field of MediaInfo has to be defined and nonempty for component " + ComponentUtils.getPathToComponent(uiComponent) + ".");
@@ -198,8 +198,8 @@ public abstract class AbstractMediaRende
String contentType = mediaInfo.getContentType();
String codec = mediaInfo.getCodec();
- boolean contentTypeDefined = contentType != null && !contentType.isEmpty();
- boolean codecDefined = codec != null && !codec.isEmpty();
+ boolean contentTypeDefined = contentType != null && contentType.length() > 0;
+ boolean codecDefined = codec != null && codec.length() > 0;
// if codec is set, then contentType should be set too!
if (codecDefined && !contentTypeDefined)
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/renderkit/util/Html5RendererUtils.java Mon Aug 29 19:47:48 2011
@@ -264,7 +264,7 @@ public class Html5RendererUtils
{
String strValues = (String) value;
- if (strValues.isEmpty())
+ if (strValues.length() == 0)
return defaultValue;
// if value is comma separated words, split it
@@ -276,7 +276,7 @@ public class Html5RendererUtils
{
strValueElement = strValueElement.trim();
- if (!strValueElement.isEmpty())
+ if (strValueElement.length() > 0)
valuesCollection.add(strValueElement);
}
}
Modified: myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/validator/DateTimeRangeValidator.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/validator/DateTimeRangeValidator.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/validator/DateTimeRangeValidator.java (original)
+++ myfaces/html5/trunk/myfaces-html5-core/src/main/java/org/apache/myfaces/html5/validator/DateTimeRangeValidator.java Mon Aug 29 19:47:48 2011
@@ -115,7 +115,7 @@ public class DateTimeRangeValidator impl
{
if (dateValue.before(resolvedMinimum) || dateValue.after(resolvedMaximum))
{
- if (this.notInRangeMessage != null && !this.notInRangeMessage.isEmpty())
+ if (this.notInRangeMessage != null && this.notInRangeMessage.length() > 0)
throw new ValidatorException(new FacesMessage(this.notInRangeMessage));
else
throw new ValidatorException(
@@ -128,7 +128,7 @@ public class DateTimeRangeValidator impl
if (resolvedMinimum != null && dateValue.before(resolvedMinimum))
{
- if (this.lessThanMinimumMessage != null && !this.lessThanMinimumMessage.isEmpty())
+ if (this.lessThanMinimumMessage != null && this.lessThanMinimumMessage.length() > 0)
throw new ValidatorException(new FacesMessage(this.lessThanMinimumMessage));
else
throw new ValidatorException(new FacesMessage("Value is before minimum for component "
@@ -138,7 +138,7 @@ public class DateTimeRangeValidator impl
if (resolvedMaximum != null && dateValue.after(resolvedMaximum))
{
- if (this.exceedMaximumMessage != null && !this.exceedMaximumMessage.isEmpty())
+ if (this.exceedMaximumMessage != null && this.exceedMaximumMessage.length() > 0)
throw new ValidatorException(new FacesMessage(this.exceedMaximumMessage));
else
throw new ValidatorException(new FacesMessage("Value is after maximum for component "
Modified: myfaces/html5/trunk/myfaces-html5-demo/pom.xml
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-demo/pom.xml?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-demo/pom.xml (original)
+++ myfaces/html5/trunk/myfaces-html5-demo/pom.xml Mon Aug 29 19:47:48 2011
@@ -121,6 +121,13 @@
</dependency>
<dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>jsr250-api</artifactId>
+ <version>1.0</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>1.1.1</version>
Modified: myfaces/html5/trunk/myfaces-html5-demo/src/main/java/org/apache/myfaces/html5/demo/bean/DndBean.java
URL: http://svn.apache.org/viewvc/myfaces/html5/trunk/myfaces-html5-demo/src/main/java/org/apache/myfaces/html5/demo/bean/DndBean.java?rev=1162961&r1=1162960&r2=1162961&view=diff
==============================================================================
--- myfaces/html5/trunk/myfaces-html5-demo/src/main/java/org/apache/myfaces/html5/demo/bean/DndBean.java (original)
+++ myfaces/html5/trunk/myfaces-html5-demo/src/main/java/org/apache/myfaces/html5/demo/bean/DndBean.java Mon Aug 29 19:47:48 2011
@@ -112,7 +112,7 @@ public class DndBean implements Serializ
public void processJavaProjectDrop(DropEvent event) throws AbortProcessingException
{
String param = event.getParam();
- if (param == null || param.isEmpty())
+ if (param == null || param.length() == 0)
return;
ApacheProject droppedProject = null;
@@ -140,7 +140,7 @@ public class DndBean implements Serializ
public void processCProjectDrop(DropEvent event) throws AbortProcessingException
{
String param = event.getParam();
- if (param == null || param.isEmpty())
+ if (param == null || param.length() == 0)
return;
ApacheProject droppedProject = null;
@@ -168,7 +168,7 @@ public class DndBean implements Serializ
public void processProjectDrop(DropEvent event) throws AbortProcessingException
{
String param = event.getParam();
- if (param == null || param.isEmpty())
+ if (param == null || param.length() == 0)
return;
ApacheProject droppedProject = null;