You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Stefan Seifert <ss...@pro-vision.de> on 2016/02/05 22:41:29 UTC

RE: MockSlingHttpServletResponse doesn't support getLocale()

i've created https://issues.apache.org/jira/browse/SLING-5490 for this

stefan

>-----Original Message-----
>From: Justin Edelson [mailto:justin@justinedelson.com]
>Sent: Friday, January 22, 2016 5:54 PM
>To: dev@sling.apache.org
>Subject: MockSlingHttpServletResponse doesn't support getLocale()
>
>Hi,
>I was looking at MockSlingHttpServletResponse (
>https://github.com/apache/sling/blob/trunk/bundles/extensions/servlet-
>helpers/src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletR
>esponse.java)
>and was wondering if there was a specific reason why getLocale() isn't
>supported. IIUC (and to be honest, I wasn't 100% following this
>discussion), this class is now intended to be used in concert with the
>SlingRequestProcessor interface (as opposed to just unit tests). If so, it
>seems like supporting getLocale() would be important as servlets/scripts
>might depend upon this.
>
>I can make this change super-quick, but wanted to check first to see if
>there was a reason not to implement it.
>
>Thanks,
>Justin