You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/08/01 11:13:14 UTC
[kudu-CR](branch-1.17.x) [compile] fix a compile warning
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20290
to review the following change.
Change subject: [compile] fix a compile warning
......................................................................
[compile] fix a compile warning
I noticed that there is a warning during the compile process:
`
/data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function ‘virtual void kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’:
/data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: ‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized]
update_immu_col_to_null_ ? nullopt : optional<int>(999));
`
Although it does not involve functional defects, it
still needs to be fixed.
As it does not involve any logic changes, no new unit tests
have been added.
Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Reviewed-on: http://gerrit.cloudera.org:8080/20183
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 7f9b3e3e29d951c35d4c28fe9f90b9f7cabe873f)
---
M src/kudu/client/client-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/20290/1
--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) [compile] fix a compile warning
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20290 )
Change subject: [compile] fix a compile warning
......................................................................
[compile] fix a compile warning
I noticed that there is a warning during the compile process:
`
/data/github-kudu/kudu/src/kudu/client/client-test.cc: In member function ‘virtual void kudu::client::ClientTestImmutableColumn_TestUpsert_Test::TestBody()’:
/data/github-kudu/kudu/src/kudu/client/client-test.cc:9562:90: warning: ‘iftmp.3716’ may be used uninitialized in this function [-Wmaybe-uninitialized]
update_immu_col_to_null_ ? nullopt : optional<int>(999));
`
Although it does not involve functional defects, it
still needs to be fixed.
As it does not involve any logic changes, no new unit tests
have been added.
Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Reviewed-on: http://gerrit.cloudera.org:8080/20183
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 7f9b3e3e29d951c35d4c28fe9f90b9f7cabe873f)
Reviewed-on: http://gerrit.cloudera.org:8080/20290
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/client/client-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [compile] fix a compile warning
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [compile] fix a compile warning
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [compile] fix a compile warning
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20290 )
Change subject: [compile] fix a compile warning
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 01 Aug 2023 11:19:09 +0000
Gerrit-HasComments: No