You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/12 17:20:46 UTC
[PR] test: cover provider hardening regressions [rocketmq-dashboard]
tju-yxq opened a new pull request, #2034:
URL: https://github.com/apache/rocketmq-dashboard/pull/2034
## What is the purpose of the change
Follow-up hardening and regression coverage for provider issues #1407, #1411, #1415, #1422, and #1428.
This PR is based on repository inspection and focused unit tests. It does not claim live broker, UI, ONS/cloud, retention-cleanup, or SSRF exploit reproduction.
## Brief changelog
- Added direct `SystemTopicFilter` regression coverage for shared system-topic filtering, including dynamic broker-name filtering.
- Made message trace timestamp resolution use the supplied topic hint before falling back to decoded offset-message-id lookup.
- Added trace-window tests for topic-hinted lookup and fallback one-hour behavior.
- Tightened DLQ resend user-property copying so reserved tag/key/wait properties are not copied as user properties.
- Added DLQ resend test covering copied business properties and skipped reserved properties.
- Added explicit loopback IPv4 data-source rejection test.
- Scoped topic/group delete broker operations to selected cluster brokers instead of all brokers, and added multi-cluster tests for create/delete topic/group operations.
## Verification
```bash
cd server
mvn -DskipTests=false "-Dtest=SystemTopicFilterTest,RocketMQMessageProviderTest#getMessageTraceShouldDeriveWindowFromTopicMessageStoreTimestamp+getMessageTraceShouldUseFallbackOneHourWindowWhenMessageTimestampCannotBeResolved+offsetMessageIdFixtureShouldDecodeToBrokerAddressForTraceWindowTests,RocketMQDLQProviderTest#resendMessagesShouldCopyUserPropertiesAndSkipSystemProperties,SettingsServiceTest#testConnectionShouldRejectLoopbackIpv4Address,RocketMQAdminClientImplTest#createTopicShouldOnlyWriteTargetClusterBrokersInMultiClusterTopology+deleteTopicScopesBrokerDeletionToSelectedClusterOnly+deleteConsumerGroupScopesBrokerDeletionToSelectedClusterOnly" test
```
Result: `BUILD SUCCESS`; `Tests run: 9, Failures: 0, Errors: 0, Skipped: 0`.
## Notes
- Full project verification was not run.
- No live broker/UI/cloud/SSRF environment was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover provider hardening regressions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #2034:
URL: https://github.com/apache/rocketmq-dashboard/pull/2034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org