You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/12 16:10:44 UTC

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1554: Enhance DefaultJobClassNameProvider and complete testcases

TeslaCN opened a new pull request #1554:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1554


   Fixes #1553 
   
   Changes proposed in this pull request:
   - Extract magic value to constant. 
   - Add testcases for DefaultJobClassNameProvider.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1554: Enhance DefaultJobClassNameProvider and complete testcases

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1554:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1554#issuecomment-707239220


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554?src=pr&el=h1) Report
   > Merging [#1554](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/5b8199cce95330ef4a425837e6a032deec6eefaf?el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1554      +/-   ##
   ============================================
   + Coverage     85.07%   85.09%   +0.01%     
     Complexity      101      101              
   ============================================
     Files           247      247              
     Lines          5683     5683              
     Branches        890      890              
   ============================================
   + Hits           4835     4836       +1     
   + Misses          534      533       -1     
     Partials        314      314              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...te/internal/setup/DefaultJobClassNameProvider.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2V0dXAvRGVmYXVsdEpvYkNsYXNzTmFtZVByb3ZpZGVyLmphdmE=) | `83.33% <50.00%> (+33.33%)` | `1.00 <0.00> (ø)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554?src=pr&el=footer). Last update [5b8199c...c47ae71](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1554?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1554: Enhance DefaultJobClassNameProvider and complete testcases

Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1554:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1554


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org