[GitHub] [spark] srielau commented on pull request #36151: WIP: [SPARK-27998] [SQL] Add support for double-quoted named expressions

[GitBox <gi...@apache.org>]

srielau commented on PR #36151:
URL: https://github.com/apache/spark/pull/36151#issuecomment-1099601695

   I think this this is worrysome for two reasons
   
   1. It adds confusion between what is a string and what is an identifier.
   2. It singles out a specific kind of an identifier (column) and a specific narrow kind of context (column aliasing in the select list).
   
   I totally  for a switch that sets whether double quotes are used for identifiers or strings.
   but it should be:
   
   1. Pick one
   2. Holistic 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org