You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "plusplusjiajia (via GitHub)" <gi...@apache.org> on 2026/08/05 09:14:21 UTC

[PR] fix: redact secret property values in SessionContext Debug [iceberg-rust]

plusplusjiajia opened a new pull request, #2960:
URL: https://github.com/apache/iceberg-rust/pull/2960

   ## What changes are included in this PR?
   
     `SessionContext`'s derived `Debug` printed `properties` verbatim, while session properties routinely carry secrets (`token`, `s3.secret-access-key`, ...). A hand-written `Debug` now redacts values of sensitive keys, matched
     case-insensitively and separator-agnostically (`AWS_SECRET_ACCESS_KEY`, `clientSecret`, `adls.connection.string`, ...) since property keys carry no casing contract — so `Credential`'s redaction isn't undone by the map next to it. 
   
   ## Are these changes tested?
   
     A table-driven test pins `is_sensitive_prop` across casings and separators plus negative cases, and a `Debug` formatting test asserts secret values are redacted while plain values remain visible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: redact secret property values in SessionContext Debug [iceberg-rust]

Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk commented on PR #2960:
URL: https://github.com/apache/iceberg-rust/pull/2960#issuecomment-5340768385

   I also don't think this added much value. It should be user's responsibility to put sensitive properties in credentials, and it's hard to figure out what property is sensitive from keys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: redact secret property values in SessionContext Debug [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on PR #2960:
URL: https://github.com/apache/iceberg-rust/pull/2960#issuecomment-5335680915

   Do we really need this? The sessionContext will be fully controlled by users, and they can set them in `credentials` if they want to keep them redacted


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: redact secret property values in SessionContext Debug [iceberg-rust]

Posted by "plusplusjiajia (via GitHub)" <gi...@apache.org>.
plusplusjiajia commented on PR #2960:
URL: https://github.com/apache/iceberg-rust/pull/2960#issuecomment-5336755160

   > Do we really need this? The sessionContext will be fully controlled by users, and they can set them in `credentials` if they want to keep them redacted
   
   Fair question — credentials didn't exist when I opened this (it came with #2971), and with it there, redacting by key name is largely redundant.
   What it doesn't cover is a secret embedded in a value that is legitimately a property: the SQL catalog's uri is postgres://user:pass@host/db, and SessionContext still derives Debug. Happy to cut this down to just that case, or close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: redact secret property values in SessionContext Debug [iceberg-rust]

Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk commented on PR #2960:
URL: https://github.com/apache/iceberg-rust/pull/2960#issuecomment-5340776766

   I'll close this pr for now, feel free to reopen it if necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: redact secret property values in SessionContext Debug [iceberg-rust]

Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk closed pull request #2960: fix: redact secret property values in SessionContext Debug
URL: https://github.com/apache/iceberg-rust/pull/2960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org