You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2026/02/22 19:13:48 UTC
[PR] Configure EditorConfig for groovy,cff,yaml,yml [shiro]
jbampton opened a new pull request, #2576:
URL: https://github.com/apache/shiro/pull/2576
Indent size and spacing set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure EditorConfig for groovy,cff,yaml,yml [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #2576:
URL: https://github.com/apache/shiro/pull/2576#discussion_r2838437528
##########
.editorconfig:
##########
@@ -26,6 +26,10 @@ charset = utf-8
end_of_line = lf
insert_final_newline = true
-[*.rdf]
+[*.{groovy,rdf}]
indent_size = 4
indent_style = space
+
+[*.{cff,yaml,yml}]
+indent_size = 2
Review Comment:
Ok... It looks like it's a mix between the 2 and 4-space files. I personally prefer 2-spaces. I wonder what others think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure EditorConfig for groovy,cff,yaml,yml [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #2576:
URL: https://github.com/apache/shiro/pull/2576#discussion_r2838418885
##########
.editorconfig:
##########
@@ -26,6 +26,10 @@ charset = utf-8
end_of_line = lf
insert_final_newline = true
-[*.rdf]
+[*.{groovy,rdf}]
indent_size = 4
indent_style = space
+
+[*.{cff,yaml,yml}]
+indent_size = 2
Review Comment:
I think that's already the default. But yes, if there are 2-spaced yaml files hanging around, they should be 4-spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure EditorConfig for groovy,cff,yaml,yml [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #2576:
URL: https://github.com/apache/shiro/pull/2576#discussion_r2838403490
##########
.editorconfig:
##########
@@ -26,6 +26,10 @@ charset = utf-8
end_of_line = lf
insert_final_newline = true
-[*.rdf]
+[*.{groovy,rdf}]
indent_size = 4
indent_style = space
+
+[*.{cff,yaml,yml}]
+indent_size = 2
Review Comment:
should be 4 to remain consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure EditorConfig for groovy,cff,yaml,yml [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #2576:
URL: https://github.com/apache/shiro/pull/2576#discussion_r2843038060
##########
.editorconfig:
##########
@@ -26,6 +26,10 @@ charset = utf-8
end_of_line = lf
insert_final_newline = true
-[*.rdf]
+[*.{groovy,rdf}]
indent_size = 4
indent_style = space
+
+[*.{cff,yaml,yml}]
+indent_size = 2
Review Comment:
I think we have concensues... 2 spaces for YAML files are good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure EditorConfig for groovy,cff,yaml,yml [shiro]
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on code in PR #2576:
URL: https://github.com/apache/shiro/pull/2576#discussion_r2838411618
##########
.editorconfig:
##########
@@ -26,6 +26,10 @@ charset = utf-8
end_of_line = lf
insert_final_newline = true
-[*.rdf]
+[*.{groovy,rdf}]
indent_size = 4
indent_style = space
+
+[*.{cff,yaml,yml}]
+indent_size = 2
Review Comment:
> should be 4 to remain consistent
Should I reformat the "YAML" files so they all have 4 spaces ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure EditorConfig for groovy,cff,yaml,yml [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #2576:
URL: https://github.com/apache/shiro/pull/2576#discussion_r2838437528
##########
.editorconfig:
##########
@@ -26,6 +26,10 @@ charset = utf-8
end_of_line = lf
insert_final_newline = true
-[*.rdf]
+[*.{groovy,rdf}]
indent_size = 4
indent_style = space
+
+[*.{cff,yaml,yml}]
+indent_size = 2
Review Comment:
Ok... It looks like it's a mix between the 2. I personally prefer 2-spaces. I wonder what others think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org