You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/01/25 01:17:11 UTC

Review Request 17339: Made proposal number optional in log::catchup.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17339/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/log/catchup.hpp 3652830 
  src/log/catchup.cpp 5825eae 
  src/log/recover.cpp ee38acd 

Diff: https://reviews.apache.org/r/17339/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 17339: Made proposal number optional in log::catchup.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17339/#review32767
-----------------------------------------------------------

Ship it!



src/log/catchup.cpp
<https://reviews.apache.org/r/17339/#comment61742>

    Maybe 'proposal.get(0)'?


- Benjamin Hindman


On Jan. 25, 2014, 12:17 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17339/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2014, 12:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/catchup.hpp 3652830 
>   src/log/catchup.cpp 5825eae 
>   src/log/recover.cpp ee38acd 
> 
> Diff: https://reviews.apache.org/r/17339/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 17339: Made proposal number optional in log::catchup.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17339/
-----------------------------------------------------------

(Updated Jan. 25, 2014, 12:56 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

BenH's.


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  src/log/catchup.hpp 3652830 
  src/log/catchup.cpp 5825eae 
  src/log/recover.cpp ee38acd 

Diff: https://reviews.apache.org/r/17339/diff/


Testing
-------

make check


Thanks,

Jie Yu