You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "PJ Fanning (Jira)" <ji...@apache.org> on 2021/12/07 10:57:00 UTC
[jira] [Commented] (DRILL-8070) format-excel assumes that rowIterator returns every row - it doesn't
[ https://issues.apache.org/jira/browse/DRILL-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454580#comment-17454580 ]
PJ Fanning commented on DRILL-8070:
-----------------------------------
[~cgivre] I spotted this when looking at DRILL-8069
> format-excel assumes that rowIterator returns every row - it doesn't
> --------------------------------------------------------------------
>
> Key: DRILL-8070
> URL: https://issues.apache.org/jira/browse/DRILL-8070
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Data Types
> Reporter: PJ Fanning
> Priority: Major
>
> In ExcelBatchReader, this code makes the wrong assumption:
> {code:java}
> for (int i = 1; i < rowNumber; i++) {
> currentRow = rowIterator.next();
> } {code}
>
> There are 2 for loops like this.
> Empty Rows will not necessarily be returned by the iterator. Basically, rows without populated cells could easily be skipped. Think of the Sheet as being represented as a sparse matrix - because it is stored like this.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)