[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #295: Cleanup RuntimeException and fetchRemoteStorage logic in ClientUtils

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #295:
URL: https://github.com/apache/incubator-uniffle/pull/295#discussion_r1012832405


##########
client/src/main/java/org/apache/uniffle/client/util/ClientUtils.java:
##########
@@ -30,15 +30,15 @@ public class ClientUtils {
   // taskAttemptId is rest of 20 bit, max value is 2^20 - 1
   public static Long getBlockId(long partitionId, long taskAttemptId, long atomicInt) {
     if (atomicInt < 0 || atomicInt > Constants.MAX_SEQUENCE_NO) {
-      throw new RuntimeException("Can't support sequence[" + atomicInt
+      throw new IllegalArgumentException("Can't support sequence[" + atomicInt

Review Comment:
   RssException may be better. Because we will collect the RssException to judge the failure apps caused by RSS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org