You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/03 15:09:46 UTC
[GitHub] [spark] zero323 commented on issue #27570:
[SPARK-30820][SPARKR][ML] Add FMClassifier to SparkR
zero323 commented on issue #27570: [SPARK-30820][SPARKR][ML] Add FMClassifier to SparkR
URL: https://github.com/apache/spark/pull/27570#issuecomment-593999450
> @zero323 Sorry, one more thing: `FMClassifier `currently only supports binary classification, so the labels must be 0 and 1. The dataset `iris` you are using in the test has string label, right? Maybe change the dataset?
If you check lines 492-495 this is already handled. Honestly I am aware of any dataset that is good for binary classification, won't require any transformations, and comes from core datasets (so it doesn't create annoying dependency).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org