You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "deepujain (via GitHub)" <gi...@apache.org> on 2026/09/23 05:26:45 UTC

[PR] fix(chart): prevent stacking bars on a logarithmic axis [superset]

deepujain opened a new pull request, #44556:
URL: https://github.com/apache/superset/pull/44556

### SUMMARY

Stacked bars on a logarithmic axis can lose visible segments, as reported in #25829. This applies the requested control-panel guard: logarithmic mode disables the Stacked Style selector, and choosing a stacked style hides the logarithmic option. Turning the active setting off makes the other option available again.

A saved chart with both values already set keeps both controls accessible so the user can clear either setting. Its stored configuration and existing rendering are not silently rewritten. The change is limited to the ECharts Bar panel; shared controls, line/area charts and Mixed Timeseries remain unchanged. The logarithmic option uses the panel's visibility mechanism because the shared CheckboxControl does not support a disabled state.

Fixes #25829

### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Isolated production SelectControl and CheckboxControl components in Storybook, using the Bar panel configuration. These show the control interaction, not a full Explore page or a database-backed chart.

| Before: stacking selectable with log enabled | After: stacking disabled with log enabled |
| --- | --- |
| ![Before](https://raw.githubusercontent.com/deepujain/superset/evidence-25829-stacked-log-controls/before.png) | ![After](https://raw.githubusercontent.com/deepujain/superset/evidence-25829-stacked-log-controls/after.png) |

[Stacked mode](https://raw.githubusercontent.com/deepujain/superset/evidence-25829-stacked-log-controls/stacked.png) and [a saved invalid combination with a recovery path](https://raw.githubusercontent.com/deepujain/superset/evidence-25829-stacked-log-controls/legacy.png).

### TESTING INSTRUCTIONS

1. In an ECharts Bar chart, enable Logarithmic axis. Stacked Style is disabled; turning logarithmic mode off restores it.
2. Select Stack. The logarithmic toggle is hidden; clearing stacking restores it. Check horizontal and vertical orientations.
3. Open a saved chart whose stack and log settings are both enabled. Either setting can be cleared, without trapping the user behind two disabled controls.

Local checks:
- `jest plugins/plugin-chart-echarts/test/Timeseries/Bar/controlPanel.test.ts plugins/plugin-chart-echarts/test/Timeseries/Bar/transformProps.test.ts plugins/plugin-chart-echarts/test/MixedTimeseries/controlPanel.test.ts --runInBand`: 61 tests passed with Node 24.16.0. The five new guard cases fail against the original panel.
- `npm run plugins:build`: passed, including declaration generation.
- Staged-file `pre-commit run`: all applicable hooks passed, including frontend type checking.
- Chromium exercised the real production controls in isolated Storybook for normal, logarithmic, stacked and saved-invalid states, including recovery interactions. Full application E2E and database-backed chart rendering were not run locally.

### ADDITIONAL INFORMATION

- [x] Has associated issue: #25829
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(chart): prevent stacking bars on a logarithmic axis [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.

netlify[bot] commented on PR #44556:
URL: https://github.com/apache/superset/pull/44556#issuecomment-5792546387

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | eb418e31ae9a4268c0c6fc6f7d071d09c71faf61 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ab39e3c7cdda00008980dca |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44556--superset-docs-preview.netlify.app](https://deploy-preview-44556--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ0NTU2LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.sbxVfFbMZGhzyFBfXcI_hEmjymIif8u4XtRwGxbYM0w)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcrBDYAgDEDRXXqWhEBUcAPHqC0qEYWAB4xxd_mnf3gvpBzPdMME0MGS8aK9_eqrUL1RVpQb6XAsQtwEVl-aYpdCfGZubsBFW6dpJGaULWONZEL4fg) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-44556--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(chart): prevent stacking bars on a logarithmic axis [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.

bito-code-review[bot] commented on PR #44556:
URL: https://github.com/apache/superset/pull/44556#issuecomment-5791834369

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(chart): prevent stacking bars on a logarithmic axis [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas merged PR #44556:
URL: https://github.com/apache/superset/pull/44556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org