You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alex Petrov (Jira)" <ji...@apache.org> on 2021/10/12 11:47:00 UTC
[jira] [Commented] (CASSANDRA-16673) Avoid race in
AbstractReplicationStrategy endpoint caching
[ https://issues.apache.org/jira/browse/CASSANDRA-16673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427633#comment-17427633 ]
Alex Petrov commented on CASSANDRA-16673:
-----------------------------------------
+1, thank you for the updates. I like the new state. I think we can avoid {{maybeClear}} in {{get}} because we'll remove {{null}} anyways, and in {{put}} - because we'll CAS on a newer version anyways. I don't mind to commit without this change though.
> Avoid race in AbstractReplicationStrategy endpoint caching
> ----------------------------------------------------------
>
> Key: CASSANDRA-16673
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16673
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Membership
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
>
> We should make sure we track which ringVersion we are caching in AbstractReplicationStrategy to avoid a race where we might return the wrong EndpointsForRange.
> {code}
> Caused by: java.lang.IllegalArgumentException: 9010454139840013625 is not contained within (9223372036854775801,-4611686018427387905]
> at org.apache.cassandra.locator.EndpointsForRange.forToken(EndpointsForRange.java:59)
> at org.apache.cassandra.locator.AbstractReplicationStrategy.getNaturalReplicasForToken(AbstractReplicationStrategy.java:104)
> at org.apache.cassandra.locator.ReplicaLayout.forTokenReadLiveSorted(ReplicaLayout.java:330)
> at org.apache.cassandra.locator.ReplicaPlans.forRead(ReplicaPlans.java:594)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org