You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/08/25 23:45:04 UTC
Review Request 61920: Added a test that uses environment secrets and
the DefaultExecutor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61920/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-7916
https://issues.apache.org/jira/browse/MESOS-7916
Repository: mesos
Description
-------
This test checks that environment secrets are properly resolved and
exposed to tasks started by the DefaultExecutor.
Diffs
-----
src/tests/containerizer/environment_secret_isolator_tests.cpp 2ba156f081c3a7c47d746f4750dbd74771b341c1
Diff: https://reviews.apache.org/r/61920/diff/1/
Testing
-------
The test succeeds on GNU/Linux.
Thanks,
Gastón Kleiman
Re: Review Request 61920: Added a test that uses environment secrets
and the DefaultExecutor.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61920/
-----------------------------------------------------------
(Updated Aug. 30, 2017, 8:37 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed comments.
Bugs: MESOS-7916
https://issues.apache.org/jira/browse/MESOS-7916
Repository: mesos
Description
-------
This test checks that environment secrets are properly resolved and
exposed to tasks started by the DefaultExecutor.
Diffs (updated)
-----
src/tests/containerizer/environment_secret_isolator_tests.cpp 2ba156f081c3a7c47d746f4750dbd74771b341c1
Diff: https://reviews.apache.org/r/61920/diff/2/
Changes: https://reviews.apache.org/r/61920/diff/1-2/
Testing
-------
The test succeeds on GNU/Linux.
Thanks,
Gastón Kleiman
Re: Review Request 61920: Added a test that uses environment secrets
and the DefaultExecutor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61920/#review183910
-----------------------------------------------------------
Failed to apply patch!
Reviews applied: [61920]
Logs available here: http://104.210.40.105/logs/master/61920
- Mesos Reviewbot Windows
On Aug. 25, 2017, 11:45 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61920/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2017, 11:45 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks that environment secrets are properly resolved and
> exposed to tasks started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/environment_secret_isolator_tests.cpp 2ba156f081c3a7c47d746f4750dbd74771b341c1
>
>
> Diff: https://reviews.apache.org/r/61920/diff/1/
>
>
> Testing
> -------
>
> The test succeeds on GNU/Linux.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 61920: Added a test that uses environment secrets
and the DefaultExecutor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61920/#review183894
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61920]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 25, 2017, 11:45 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61920/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2017, 11:45 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks that environment secrets are properly resolved and
> exposed to tasks started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/environment_secret_isolator_tests.cpp 2ba156f081c3a7c47d746f4750dbd74771b341c1
>
>
> Diff: https://reviews.apache.org/r/61920/diff/1/
>
>
> Testing
> -------
>
> The test succeeds on GNU/Linux.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 61920: Added a test that uses environment secrets
and the DefaultExecutor.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
> On Aug. 30, 2017, 7:33 p.m., Greg Mann wrote:
> > src/tests/containerizer/environment_secret_isolator_tests.cpp
> > Lines 170 (patched)
> > <https://reviews.apache.org/r/61920/diff/1/?file=1804173#file1804173line170>
> >
> > Is this needed?
This avoids getting gtest warnings if for some reason the nested containers take long to execute and the driver gets another offer.
- Gastón
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61920/#review184182
-----------------------------------------------------------
On Aug. 30, 2017, 8:37 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61920/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 8:37 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks that environment secrets are properly resolved and
> exposed to tasks started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/environment_secret_isolator_tests.cpp 2ba156f081c3a7c47d746f4750dbd74771b341c1
>
>
> Diff: https://reviews.apache.org/r/61920/diff/2/
>
>
> Testing
> -------
>
> The test succeeds on GNU/Linux.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 61920: Added a test that uses environment secrets
and the DefaultExecutor.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61920/#review184182
-----------------------------------------------------------
Fix it, then Ship it!
LGTM, just a couple small nits below.
src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 170 (patched)
<https://reviews.apache.org/r/61920/#comment260257>
Is this needed?
src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 226 (patched)
<https://reviews.apache.org/r/61920/#comment260259>
s/statusRunning.get().state()/statusRunning->state()/
src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 228 (patched)
<https://reviews.apache.org/r/61920/#comment260260>
s/statusFinished.get().state()/statusFinished->state()/
- Greg Mann
On Aug. 25, 2017, 11:45 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61920/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2017, 11:45 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7916
> https://issues.apache.org/jira/browse/MESOS-7916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks that environment secrets are properly resolved and
> exposed to tasks started by the DefaultExecutor.
>
>
> Diffs
> -----
>
> src/tests/containerizer/environment_secret_isolator_tests.cpp 2ba156f081c3a7c47d746f4750dbd74771b341c1
>
>
> Diff: https://reviews.apache.org/r/61920/diff/1/
>
>
> Testing
> -------
>
> The test succeeds on GNU/Linux.
>
>
> Thanks,
>
> Gastón Kleiman
>
>