You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 12:46:27 UTC

[PR] test(broker): deepen ClusterConnectionService summary coverage [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3318:
URL: https://github.com/apache/rocketmq-dashboard/pull/3318

   ## Summary
   
   Extends the existing `ClusterConnectionServiceTest` (2 to 4 tests) to pin down the connection probe summary.
   
   Added cases:
   - a cluster whose broker list is null is summarized as connected with zero brokers and an empty broker-name list, and the message reports `0 broker(s)`;
   - with two brokers, the probe message carries the expected `Connected to 2 broker(s) in ... ms` summary.
   
   ## Why
   
   The probe powers the cluster UI test-connection action; the null-broker and message-summary branches had no coverage (only success + failure propagation existed).
   
   ## Testing
   
   `mvn -B test -Dtest=ClusterConnectionServiceTest` — 4/4 pass; checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(broker): deepen ClusterConnectionService summary coverage [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3318: test(broker): deepen ClusterConnectionService summary coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org