[GitHub] [spark] dilipbiswal edited a comment on pull request #28750: [SPARK-31916][SQL] StringConcat can lead to StringIndexOutOfBoundsException

[GitBox <gi...@apache.org>]

dilipbiswal edited a comment on pull request #28750:
URL: https://github.com/apache/spark/pull/28750#issuecomment-641766979


   @maropu 
   > Have you checked my last comment? #28750 (comment) The PR itself looks okay.
   
   Sorry i missed that. I have added the comment now.
   
   @viirya 
   > Looks okay although I think making it a long might be also good and simpler.
   
   We could make it a long. The only thing is we may still overflow but it will take perhaps long time to hit it. I can repro the StringIndexOutOfBoundsException after changing the length to long. I made a minor tweak to change the append method to fake the input's length to be Int.MaxValue and adjust the test to increase the loop count.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org