You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/22 19:27:38 UTC
[GitHub] [maven-site] sultan opened a new pull request, #331: [MNG-7559] Fix versions comparison
sultan opened a new pull request, #331:
URL: https://github.com/apache/maven-site/pull/331
Fix versions comparison https://issues.apache.org/jira/browse/MNG-7559
intention is:
* milestone < preview < rc
* .RC1 < -RC2
* -pfd < final, ga, release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
elharo commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020903880
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
Review Comment:
I'm not quite familiar with apt. Are these brackets significant for some reason or should they be removed?
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ Following semver rules is encouraged, and some qualifiers are discouraged:
+ * Prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'.
+ * Prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'.
+ * The usage of '<<<CR>>>' qualifier is discouraged. Use '<<<RC>>>' instead.
+ * The usage of '<<<final>>>', '<<<ga>>>', '<<<release>>>' qualifiers is discouraged. Use no qualifier instead.
Review Comment:
`<<<ga>>>, and <<<release>>>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #331:
URL: https://github.com/apache/maven-site/pull/331#issuecomment-1312730919
reverted one comparison, and added another test case to prove website documentation right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020900722
##########
content/apt/pom.apt.vm:
##########
@@ -527,17 +538,17 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to numeric order)
- * "<<<1.foo>>>" \< "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
+ * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
- * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
+ * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
- * "<<<1-sp>>>" \> "<<<1-ga>>>"
+ * "<<<1-sp>>>" \> "<<<1-ga>>>"
- * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
+ * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
- * "<<<1-sp-1>>>" \< "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
+ * "<<<1-sp-1>>>" \> "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
Review Comment:
i think you are right, and reverted this change
added that to my existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020900253
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
+ * prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'
+ * prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'
+ * the usage of '<<<CR>>>' qualifier is discouraged, use '<<<RC>>>' instead.
Review Comment:
ok, done.
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
+ * prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'
+ * prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'
+ * the usage of '<<<CR>>>' qualifier is discouraged, use '<<<RC>>>' instead.
+ * the usage of '<<<final>>>', '<<<ga>>>', '<<<release>>>' qualifiers is discouraged, use no qualifier instead.
Review Comment:
ok, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020916660
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
Review Comment:
i can remove them from the example if needed. in fact, any String qualifier other than 'SP' needs to be less than release for the fix to work. there is no hard coded value ea nor preview in the code fix (except tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020904598
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ Following semver rules is encouraged, and some qualifiers are discouraged:
+ * Prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'.
+ * Prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'.
+ * The usage of '<<<CR>>>' qualifier is discouraged. Use '<<<RC>>>' instead.
+ * The usage of '<<<final>>>', '<<<ga>>>', '<<<release>>>' qualifiers is discouraged. Use no qualifier instead.
Review Comment:
good catch, thank you. can you please confirm my correction is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020900207
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
+ * prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'
Review Comment:
ok, done.
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
Review Comment:
ok, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020904515
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
Review Comment:
if i am not mistaken, the brackets are needed to make a space between a list and a paragraph. otherwise the next paragraph can be mistaken for a continuation of the last bullet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020900722
##########
content/apt/pom.apt.vm:
##########
@@ -527,17 +538,17 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to numeric order)
- * "<<<1.foo>>>" \< "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
+ * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
- * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
+ * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
- * "<<<1-sp>>>" \> "<<<1-ga>>>"
+ * "<<<1-sp>>>" \> "<<<1-ga>>>"
- * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
+ * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
- * "<<<1-sp-1>>>" \< "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
+ * "<<<1-sp-1>>>" \> "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
Review Comment:
i think you are right,
added that to my existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020904079
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
+ * prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'
+ * prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'
+ * the usage of '<<<CR>>>' qualifier is discouraged, use '<<<RC>>>' instead.
Review Comment:
i used a dot between "discouraged" and "use". can you confirm this is what you wanted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on pull request #331: [MNG-7559] Fix versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #331:
URL: https://github.com/apache/maven-site/pull/331#issuecomment-1312572280
code:
* PR https://github.com/apache/maven/pull/845
documentation:
* PR https://github.com/apache/maven-site/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
elharo commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020915748
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
Review Comment:
ea and preview are new here, not previously mentioned. Were they already handled like this in the code?
If not, this is new behavior that risks breaking builds.
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ Following semver rules is encouraged, and some qualifiers are discouraged:
+ * Prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'.
+ * Prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'.
+ * The usage of '<<<CR>>>' qualifier is discouraged. Use '<<<RC>>>' instead.
+ * The usage of '<<<final>>>', '<<<ga>>>' and '<<<release>>>' qualifiers is discouraged. Use no qualifier instead.
Review Comment:
comma before and
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ Following semver rules is encouraged, and some qualifiers are discouraged:
+ * Prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'.
+ * Prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'.
+ * The usage of '<<<CR>>>' qualifier is discouraged. Use '<<<RC>>>' instead.
+ * The usage of '<<<final>>>', '<<<ga>>>' and '<<<release>>>' qualifiers is discouraged. Use no qualifier instead.
+ * The usage of '<<<SP>>>' qualifier is discouraged. Use version increment instead.
Review Comment:
Use version increment instead. --> Increment the patch version instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020917231
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ Following semver rules is encouraged, and some qualifiers are discouraged:
+ * Prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'.
+ * Prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'.
+ * The usage of '<<<CR>>>' qualifier is discouraged. Use '<<<RC>>>' instead.
+ * The usage of '<<<final>>>', '<<<ga>>>' and '<<<release>>>' qualifiers is discouraged. Use no qualifier instead.
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020900722
##########
content/apt/pom.apt.vm:
##########
@@ -527,17 +538,17 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to numeric order)
- * "<<<1.foo>>>" \< "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
+ * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
- * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
+ * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
- * "<<<1-sp>>>" \> "<<<1-ga>>>"
+ * "<<<1-sp>>>" \> "<<<1-ga>>>"
- * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
+ * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
- * "<<<1-sp-1>>>" \< "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
+ * "<<<1-sp-1>>>" \> "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
Review Comment:
i might be mistaken, but i think the doc "was" innacurate of the previous algorithm.
i think both previous and suggested algo have GA < SP.
will add that to my existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo merged pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
elharo merged PR #331:
URL: https://github.com/apache/maven-site/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020916660
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
Review Comment:
i can remove them from the example if needed. in fact, any String qualifier other than 'SP' needs to be less than release for the fix to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #331:
URL: https://github.com/apache/maven-site/pull/331#issuecomment-1312734681
> This is related to MNG-7559 but does not seem to fix it. It merely changes docs. That issue requests changes in behavior.
The test cases for MNG 7559 are here:
[maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
](https://github.com/apache/maven/pull/845/files#diff-ac21071332b41097f00464056518860fb5030e210e05e82c4ae6af6421d0f33c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #331:
URL: https://github.com/apache/maven-site/pull/331#issuecomment-1312733734
i think i resolved everything, thank you for your feedback. waiting approval of last fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020904598
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ Following semver rules is encouraged, and some qualifiers are discouraged:
+ * Prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'.
+ * Prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'.
+ * The usage of '<<<CR>>>' qualifier is discouraged. Use '<<<RC>>>' instead.
+ * The usage of '<<<final>>>', '<<<ga>>>', '<<<release>>>' qualifiers is discouraged. Use no qualifier instead.
Review Comment:
good catch, ty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on pull request #331: [MNG-7559] Fix versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #331:
URL: https://github.com/apache/maven-site/pull/331#issuecomment-1312576553
* [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #331: [MNG-7559] Fix versions comparison
Posted by GitBox <gi...@apache.org>.
elharo commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020898806
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
+ * prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'
Review Comment:
Capitialize prefer and other first words below
##########
content/apt/pom.apt.vm:
##########
@@ -527,17 +538,17 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to numeric order)
- * "<<<1.foo>>>" \< "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
+ * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
- * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
+ * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values)
- * "<<<1-sp>>>" \> "<<<1-ga>>>"
+ * "<<<1-sp>>>" \> "<<<1-ga>>>"
- * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
+ * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
- * "<<<1-sp-1>>>" \< "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
+ * "<<<1-sp-1>>>" \> "<<<1-ga-1>>>" = "<<<1-1>>>" (trailing "null" values at each hyphen)
Review Comment:
This is very iffy. What does the code actually do? It's not enough to say it in the docs. The code has to agree. I assume the current docs are accurate on how the algorithm works, absent a unit test proving otherwise.
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
Review Comment:
capitalize following
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
+ * prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'
+ * prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'
+ * the usage of '<<<CR>>>' qualifier is discouraged, use '<<<RC>>>' instead.
Review Comment:
run-on sentence. comma should be period
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ following semver rules is encouraged, and some qualifiers are discouraged:
+ * prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'
+ * prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'
+ * the usage of '<<<CR>>>' qualifier is discouraged, use '<<<RC>>>' instead.
+ * the usage of '<<<final>>>', '<<<ga>>>', '<<<release>>>' qualifiers is discouraged, use no qualifier instead.
Review Comment:
run-on sentence. comma should be period
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020917286
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
+
+ []
+
+ Following semver rules is encouraged, and some qualifiers are discouraged:
+ * Prefer '<<<alpha>>>', '<<<beta>>>' and '<<<milestone>>>' qualifiers over '<<<ea>>>' and '<<<preview>>>'.
+ * Prefer '<<<1.0.0-RC1>>>'' over '<<<1.0.0.RC1>>>'.
+ * The usage of '<<<CR>>>' qualifier is discouraged. Use '<<<RC>>>' instead.
+ * The usage of '<<<final>>>', '<<<ga>>>' and '<<<release>>>' qualifiers is discouraged. Use no qualifier instead.
+ * The usage of '<<<SP>>>' qualifier is discouraged. Use version increment instead.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] sultan commented on a diff in pull request #331: [MNG-7559] Improve documentation of versions comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on code in PR #331:
URL: https://github.com/apache/maven-site/pull/331#discussion_r1020916660
##########
content/apt/pom.apt.vm:
##########
@@ -515,7 +515,18 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can respectively be shortened to "a", "b" and "m" when directly followed by a number.
- * else "<<<.qualifier>>>" \< "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+ * else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \< "<<<.number>>>"
+
+ * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<ea>>> < <<<milestone>>> = <<<m>>> < <<<preview>>> < <<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> = <<<release>>> \< <<<sp>>>
Review Comment:
i can remove them from the example if needed. in fact, any String qualifier other than 'SP' needs to be less than release for the fix to work. there is no hard coded value 'ea' nor 'preview' in the code fix (except tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org