You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/20 16:29:13 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #8614: Sha
display touchups
rusackas opened a new pull request #8614: Sha display touchups
URL: https://github.com/apache/incubator-superset/pull/8614
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
The SHA displayed in the user menu was overhwelmingly long. This now shows only the last 8 characters for reference (1 more than github!). It also adds a colon after "Version" for consistency, and a little more line height and bottom padding on the fine print so it's less claustrophobic.
Open TODO: make the fine print act like a little menu item, and copy the full SHA on click.
Open TODO?: move the "admin user" tooltip seen in the screenshot into the menu. Not sure if we need the tooltip. Thoughts, anyone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org