[GitHub] [iceberg] rdblue commented on a change in pull request #1103: Add IcebergSerDe

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1103:
URL: https://github.com/apache/iceberg/pull/1103#discussion_r448476502



##########
File path: mr/src/test/java/org/apache/iceberg/mr/mapred/serde/objectinspector/TestIcebergObjectInspector.java
##########
@@ -38,31 +38,37 @@
 
 public class TestIcebergObjectInspector {
 
+  private int id = 0;

Review comment:
       Why was this introduced? It seems like relying on the same execution order between the schema creation and the test methods is brittle.
   
   I'd prefer to move back to fixed IDs since that's easier to test and more clear in assertions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org