You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/14 15:19:00 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #5742: arm/armv7-a/r: unified syscall registers dump
anchao opened a new pull request #5742:
URL: https://github.com/apache/incubator-nuttx/pull/5742
## Summary
arm/armv7-a/r: unified syscall registers dump
## Impact
N/A
## Testing
ci-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5742: arm/armv7-a/r: unified syscall registers dump
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #5742:
URL: https://github.com/apache/incubator-nuttx/pull/5742#discussion_r826129580
##########
File path: arch/arm/src/armv7-a/arm_syscall.c
##########
@@ -44,6 +44,41 @@
* Private Functions
****************************************************************************/
+/****************************************************************************
+ * Name: dump_syscall
+ *
+ * Description:
+ * Dump the syscall registers
+ *
+ ****************************************************************************/
+
+void dump_syscall(const char *tag, uint32_t cmd, const uint32_t *regs)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5742: arm/armv7-a/r: unified syscall registers dump
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5742:
URL: https://github.com/apache/incubator-nuttx/pull/5742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5742: arm/armv7-a/r: unified syscall registers dump
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5742:
URL: https://github.com/apache/incubator-nuttx/pull/5742#discussion_r826073362
##########
File path: arch/arm/src/armv7-r/arm_syscall.c
##########
@@ -41,6 +41,32 @@
* Private Functions
****************************************************************************/
+/****************************************************************************
+ * Name: dump_syscall
+ *
+ * Description:
+ * Dump the syscall registers
+ *
+ ****************************************************************************/
+
+void dump_syscall(char *tag, uint32_t cmd, uint32_t *regs)
Review comment:
ditto
##########
File path: arch/arm/src/armv7-a/arm_syscall.c
##########
@@ -44,6 +44,32 @@
* Private Functions
****************************************************************************/
+/****************************************************************************
+ * Name: dump_syscall
+ *
+ * Description:
+ * Dump the syscall registers
+ *
+ ****************************************************************************/
+
+void dump_syscall(char *tag, uint32_t cmd, uint32_t *regs)
Review comment:
add const for tag and regs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5742: arm/armv7-a/r: unified syscall registers dump
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5742:
URL: https://github.com/apache/incubator-nuttx/pull/5742#discussion_r826128389
##########
File path: arch/arm/src/armv7-a/arm_syscall.c
##########
@@ -44,6 +44,41 @@
* Private Functions
****************************************************************************/
+/****************************************************************************
+ * Name: dump_syscall
+ *
+ * Description:
+ * Dump the syscall registers
+ *
+ ****************************************************************************/
+
+void dump_syscall(const char *tag, uint32_t cmd, const uint32_t *regs)
Review comment:
static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5742: arm/armv7-a/r: unified syscall registers dump
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5742:
URL: https://github.com/apache/incubator-nuttx/pull/5742#discussion_r826128637
##########
File path: arch/arm/src/armv7-r/arm_syscall.c
##########
@@ -41,6 +41,41 @@
* Private Functions
****************************************************************************/
+/****************************************************************************
+ * Name: dump_syscall
+ *
+ * Description:
+ * Dump the syscall registers
+ *
+ ****************************************************************************/
+
+void dump_syscall(const char *tag, uint32_t cmd, const uint32_t *regs)
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5742: arm/armv7-a/r: unified syscall registers dump
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #5742:
URL: https://github.com/apache/incubator-nuttx/pull/5742#discussion_r826129762
##########
File path: arch/arm/src/armv7-r/arm_syscall.c
##########
@@ -41,6 +41,41 @@
* Private Functions
****************************************************************************/
+/****************************************************************************
+ * Name: dump_syscall
+ *
+ * Description:
+ * Dump the syscall registers
+ *
+ ****************************************************************************/
+
+void dump_syscall(const char *tag, uint32_t cmd, const uint32_t *regs)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org