You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2024/05/23 14:30:25 UTC
[I] bug: `PrimitiveLiteral` and `Literal` should not be `Ord`. [iceberg-rust]
liurenjie1024 opened a new issue, #378:
URL: https://github.com/apache/iceberg-rust/issues/378
In rust, `Ord` means total order, while `PartiarOrd` mean partital order. Currently we have derived `Ord` for both `PrimitiveLiteral` and `Literal`, which is incorrect. How could we compare `Struct` with `Map`, or `Date` with `String`? We should do following changes:
1. Remove `PartialOrd`, `Ord` for both `Literal`.
2. Remove `Ord` for `PrimitiveLiteral`. I think we should also remove `PartialOrd` for `PrimitiveLiteral`, which misses type information for decimal.
3. Implement `PartialOrd` for `Datum`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] bug: `PrimitiveLiteral` and `Literal` should not be `Ord`. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #378:
URL: https://github.com/apache/iceberg-rust/issues/378#issuecomment-2128292132
cc @sdd @marvinlanhenke @Xuanwo @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] bug: `PrimitiveLiteral` and `Literal` should not be `Ord`. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #378:
URL: https://github.com/apache/iceberg-rust/issues/378#issuecomment-2127281854
I think this is blocking prs with filter related, such as #363 and #367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] bug: `PrimitiveLiteral` and `Literal` should not be `Ord`. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #378: bug: `PrimitiveLiteral` and `Literal` should not be `Ord`.
URL: https://github.com/apache/iceberg-rust/issues/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org