You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/03/26 17:45:28 UTC

[jira] Created: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

BytesWritable.toString prints bytes above 0x80 as FFFFFF80
----------------------------------------------------------

                 Key: HADOOP-3094
                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
             Project: Hadoop Core
          Issue Type: Bug
          Components: io
            Reporter: Owen O'Malley
            Assignee: Owen O'Malley
             Fix For: 0.17.0


The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3094:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Owen!

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582421#action_12582421 ] 

Hadoop QA commented on HADOOP-3094:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12378648/neg-bytes-writable.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2066/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2066/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2066/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2066/console

This message is automatically generated.

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582619#action_12582619 ] 

Hudson commented on HADOOP-3094:
--------------------------------

Integrated in Hadoop-trunk #443 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/443/])

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3094:
----------------------------------

    Attachment: neg-bytes-writable.patch

This patch does the obvious anding with 0xff and adds a test case.

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3094:
----------------------------------

    Attachment: neg-bytes-writable.patch

Fixed an accidental inclusion

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3094:
----------------------------------

    Status: Patch Available  (was: Open)

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582366#action_12582366 ] 

Arun C Murthy commented on HADOOP-3094:
---------------------------------------

+1

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3094:
----------------------------------

    Status: Open  (was: Patch Available)

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3094:
----------------------------------

    Status: Patch Available  (was: Open)

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3094) BytesWritable.toString prints bytes above 0x80 as FFFFFF80

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3094:
----------------------------------

    Attachment:     (was: neg-bytes-writable.patch)

> BytesWritable.toString prints bytes above 0x80 as FFFFFF80
> ----------------------------------------------------------
>
>                 Key: HADOOP-3094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3094
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.17.0
>
>         Attachments: neg-bytes-writable.patch
>
>
> The printing of BytesWritable as a series of bytes does the wrong thing with negative bytes and expands them out to 32 bits before printing them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.