You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2017/03/26 18:59:28 UTC

wicket git commit: WICKET-6336 Make SessionEntry#removePage(IManageablePage) synchronized.

Repository: wicket
Updated Branches:
  refs/heads/master df5f141d7 -> 8a4e1b3c2


WICKET-6336 Make SessionEntry#removePage(IManageablePage) synchronized.

Access to #sessionCache field must be synchronized.

Reported privately by Louis-Philippe Querel (and FindBugs).


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8a4e1b3c
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8a4e1b3c
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8a4e1b3c

Branch: refs/heads/master
Commit: 8a4e1b3c24f4ce1fc3e44ca1b5a9230158d9b584
Parents: df5f141
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Sun Mar 26 20:58:04 2017 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Sun Mar 26 20:58:04 2017 +0200

----------------------------------------------------------------------
 .../src/main/java/org/apache/wicket/page/PageStoreManager.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/8a4e1b3c/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java b/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java
index 40f294c..f5c17bd 100644
--- a/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java
+++ b/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java
@@ -156,7 +156,7 @@ public class PageStoreManager extends AbstractPageManager
 			}
 		}
 
-		private void removePage(IManageablePage page)
+		private synchronized void removePage(IManageablePage page)
 		{
 			if (page != null)
 			{