You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/11/24 18:44:53 UTC

Review Request 28395: Refactor version comparisons to use function

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28395/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.


Bugs: AMBARI-8429
    https://issues.apache.org/jira/browse/AMBARI-8429


Repository: ambari


Description
-------

In Ambari 1.7.0, we started introducing checks for the HDP version like
stack_is_hdp22_or_further = not (stack_version.startswith('2.0') or stack_version.startswith('2.1'))
This may lead to problems in future HDP versions.
Instead, we should create a function/class for doing version comparisons.
ambari-server.py already has a method called compare_versions() that compares the each segment of a version (separated by dots).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java a02f49d 
  ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java 1484698 

Diff: https://reviews.apache.org/r/28395/diff/


Testing
-------

[INFO] Ambari Main ....................................... SUCCESS [4.979s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.327s]
[INFO] Ambari Web ........................................ SUCCESS [49.858s]
[INFO] Ambari Views ...................................... SUCCESS [2.629s]
[INFO] Ambari Admin View ................................. SUCCESS [10.618s]
[INFO] Ambari Server ..................................... SUCCESS [31:41.344s]
[INFO] Ambari Agent ...................................... SUCCESS [14.152s]
[INFO] Ambari Client ..................................... SUCCESS [0.097s]
[INFO] Ambari Python Client .............................. SUCCESS [0.372s]
[INFO] Ambari Groovy Client .............................. SUCCESS [11.151s]
[INFO] Ambari Shell ...................................... SUCCESS [0.038s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.056s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.568s]


Thanks,

Dmytro Sen


Re: Review Request 28395: Refactor version comparisons to use function

Posted by Dmytro Sen <ds...@hortonworks.com>.

> On Ноя. 24, 2014, 5:50 п.п., Dmitro Lisnichenko wrote:
> > Looks like wrong patch

Yeah, sorry. Updated.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28395/#review62810
-----------------------------------------------------------


On Ноя. 24, 2014, 5:53 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28395/
> -----------------------------------------------------------
> 
> (Updated Ноя. 24, 2014, 5:53 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-8429
>     https://issues.apache.org/jira/browse/AMBARI-8429
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari 1.7.0, we started introducing checks for the HDP version like
> stack_is_hdp22_or_further = not (stack_version.startswith('2.0') or stack_version.startswith('2.1'))
> This may lead to problems in future HDP versions.
> Instead, we should create a function/class for doing version comparisons.
> ambari-server.py already has a method called compare_versions() that compares the each segment of a version (separated by dots).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py b7e3a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py 7f0e70f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 4bf9809 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py e657002 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 0e4f906 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 7022993 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 97403e8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py e9dd18c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 32b5307 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 49ac408 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py a86d6dc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 1110544 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py c1279d8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/startHiveserver2.sh.j2 3ddf50f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py bab1d78 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 71d1492 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 8cbd1a5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 80aa269 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py e174e5a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 5e066d9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 4348d5f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py e652fff 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py 4803050 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/storm.py 948a53b 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py 50f6d73 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py 83d6d73 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py 326d678 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py 467a29f 
> 
> Diff: https://reviews.apache.org/r/28395/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Ambari Main ....................................... SUCCESS [4.979s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.327s]
> [INFO] Ambari Web ........................................ SUCCESS [49.858s]
> [INFO] Ambari Views ...................................... SUCCESS [2.629s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.618s]
> [INFO] Ambari Server ..................................... SUCCESS [31:41.344s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.152s]
> [INFO] Ambari Client ..................................... SUCCESS [0.097s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.372s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.151s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.056s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.568s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 28395: Refactor version comparisons to use function

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28395/#review62810
-----------------------------------------------------------


Looks like wrong patch

- Dmitro Lisnichenko


On Nov. 24, 2014, 5:44 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28395/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 5:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-8429
>     https://issues.apache.org/jira/browse/AMBARI-8429
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari 1.7.0, we started introducing checks for the HDP version like
> stack_is_hdp22_or_further = not (stack_version.startswith('2.0') or stack_version.startswith('2.1'))
> This may lead to problems in future HDP versions.
> Instead, we should create a function/class for doing version comparisons.
> ambari-server.py already has a method called compare_versions() that compares the each segment of a version (separated by dots).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java a02f49d 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java 1484698 
> 
> Diff: https://reviews.apache.org/r/28395/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Ambari Main ....................................... SUCCESS [4.979s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.327s]
> [INFO] Ambari Web ........................................ SUCCESS [49.858s]
> [INFO] Ambari Views ...................................... SUCCESS [2.629s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.618s]
> [INFO] Ambari Server ..................................... SUCCESS [31:41.344s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.152s]
> [INFO] Ambari Client ..................................... SUCCESS [0.097s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.372s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.151s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.056s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.568s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 28395: Refactor version comparisons to use function

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28395/#review62840
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Nov. 24, 2014, 5:53 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28395/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 5:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-8429
>     https://issues.apache.org/jira/browse/AMBARI-8429
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari 1.7.0, we started introducing checks for the HDP version like
> stack_is_hdp22_or_further = not (stack_version.startswith('2.0') or stack_version.startswith('2.1'))
> This may lead to problems in future HDP versions.
> Instead, we should create a function/class for doing version comparisons.
> ambari-server.py already has a method called compare_versions() that compares the each segment of a version (separated by dots).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py b7e3a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py 7f0e70f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 4bf9809 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py e657002 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 0e4f906 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 7022993 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 97403e8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py e9dd18c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 32b5307 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 49ac408 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py a86d6dc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 1110544 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py c1279d8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/startHiveserver2.sh.j2 3ddf50f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py bab1d78 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 71d1492 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 8cbd1a5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 80aa269 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py e174e5a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 5e066d9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 4348d5f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py e652fff 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py 4803050 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/storm.py 948a53b 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py 50f6d73 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py 83d6d73 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py 326d678 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py 467a29f 
> 
> Diff: https://reviews.apache.org/r/28395/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Ambari Main ....................................... SUCCESS [4.979s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.327s]
> [INFO] Ambari Web ........................................ SUCCESS [49.858s]
> [INFO] Ambari Views ...................................... SUCCESS [2.629s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.618s]
> [INFO] Ambari Server ..................................... SUCCESS [31:41.344s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.152s]
> [INFO] Ambari Client ..................................... SUCCESS [0.097s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.372s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.151s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.056s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.568s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 28395: Refactor version comparisons to use function

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28395/#review62865
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 24, 2014, 5:53 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28395/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 5:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-8429
>     https://issues.apache.org/jira/browse/AMBARI-8429
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari 1.7.0, we started introducing checks for the HDP version like
> stack_is_hdp22_or_further = not (stack_version.startswith('2.0') or stack_version.startswith('2.1'))
> This may lead to problems in future HDP versions.
> Instead, we should create a function/class for doing version comparisons.
> ambari-server.py already has a method called compare_versions() that compares the each segment of a version (separated by dots).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py b7e3a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py 7f0e70f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 4bf9809 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py e657002 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 0e4f906 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 7022993 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 97403e8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py e9dd18c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 32b5307 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 49ac408 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py a86d6dc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 1110544 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py c1279d8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/startHiveserver2.sh.j2 3ddf50f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py bab1d78 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 71d1492 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 8cbd1a5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 80aa269 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py e174e5a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 5e066d9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 4348d5f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py e652fff 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py 4803050 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/storm.py 948a53b 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py 50f6d73 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py 83d6d73 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py 326d678 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py 467a29f 
> 
> Diff: https://reviews.apache.org/r/28395/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Ambari Main ....................................... SUCCESS [4.979s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.327s]
> [INFO] Ambari Web ........................................ SUCCESS [49.858s]
> [INFO] Ambari Views ...................................... SUCCESS [2.629s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.618s]
> [INFO] Ambari Server ..................................... SUCCESS [31:41.344s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.152s]
> [INFO] Ambari Client ..................................... SUCCESS [0.097s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.372s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.151s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.056s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.568s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 28395: Refactor version comparisons to use function

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28395/
-----------------------------------------------------------

(Updated Ноя. 24, 2014, 5:53 п.п.)


Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.


Bugs: AMBARI-8429
    https://issues.apache.org/jira/browse/AMBARI-8429


Repository: ambari


Description
-------

In Ambari 1.7.0, we started introducing checks for the HDP version like
stack_is_hdp22_or_further = not (stack_version.startswith('2.0') or stack_version.startswith('2.1'))
This may lead to problems in future HDP versions.
Instead, we should create a function/class for doing version comparisons.
ambari-server.py already has a method called compare_versions() that compares the each segment of a version (separated by dots).


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py b7e3a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py 7f0e70f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 4bf9809 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py e657002 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 0e4f906 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 7022993 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 97403e8 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py e9dd18c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 32b5307 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 49ac408 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py a86d6dc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 1110544 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py c1279d8 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/startHiveserver2.sh.j2 3ddf50f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py bab1d78 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 71d1492 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py 8cbd1a5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 80aa269 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py e174e5a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 5e066d9 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py 4348d5f 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py e652fff 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py 4803050 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/storm.py 948a53b 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py 50f6d73 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py 83d6d73 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py 326d678 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py 467a29f 

Diff: https://reviews.apache.org/r/28395/diff/


Testing
-------

[INFO] Ambari Main ....................................... SUCCESS [4.979s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.327s]
[INFO] Ambari Web ........................................ SUCCESS [49.858s]
[INFO] Ambari Views ...................................... SUCCESS [2.629s]
[INFO] Ambari Admin View ................................. SUCCESS [10.618s]
[INFO] Ambari Server ..................................... SUCCESS [31:41.344s]
[INFO] Ambari Agent ...................................... SUCCESS [14.152s]
[INFO] Ambari Client ..................................... SUCCESS [0.097s]
[INFO] Ambari Python Client .............................. SUCCESS [0.372s]
[INFO] Ambari Groovy Client .............................. SUCCESS [11.151s]
[INFO] Ambari Shell ...................................... SUCCESS [0.038s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.056s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.568s]


Thanks,

Dmytro Sen