You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hutiefang76 (via GitHub)" <gi...@apache.org> on 2026/10/24 06:42:20 UTC
[PR] GH-1386: Zero-pad inline views during split and transfer [arrow-java]
hutiefang76 opened a new pull request, #1387:
URL: https://github.com/apache/arrow-java/pull/1387
## What's Changed
`splitAndTransfer` allocates a new view buffer but only writes the length and payload of inline values. When the allocator returns non-zero memory, the remaining bytes violate the view layout's zero-padding requirement. Clear just the unused inline bytes after copying the payload; the long-value path is unchanged.
Add deterministic regressions for UTF-8 and binary views using buffers prefilled with `0xff`. They cover lengths 0, 1, 11, 12 and 13, nulls, a non-zero split offset, source preservation and allocator cleanup. Both new tests fail against the unmodified implementation with an unexpected `0xff` padding byte.
Validation on JDK 21:
- `mvn -B -ntp -Dmaven.gitcommitid.nativegit=true -pl vector -am verify` passed. The vector module ran 1193 cases in each of its two configured allocator executions, with 4 skipped per execution and no failures or errors.
- The full `TestVariableWidthViewVector` class passed all 59 cases in each execution, with no skips.
- Spotless and Checkstyle passed. The native Git option is needed locally for the existing Git plugin's worktree support; no build configuration was changed.
Closes #1386.
<sub>AI-generated PR description. Source investigation, implementation and automated review assisted by Codex and DeepSeek.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1386: Zero-pad inline views during split and transfer [arrow-java]
Posted by "hutiefang76 (via GitHub) via github" <gi...@arrow.apache.org>.
hutiefang76 commented on PR #1387:
URL: https://github.com/apache/arrow-java/pull/1387#issuecomment-6697257053
I checked the logs from the November 6 rerun at `bde43f264218298ddfd6da470aa8cb460180778d`:
- [pre-commit](https://github.com/apache/arrow-java/actions/runs/40071257010/job/127995103519): `cmake-format` raises `ValueError: Cannot use capturing groups in re.Scanner` under Python 3.15.2 while processing `adapter/orc/CMakeLists.txt` and `gandiva/CMakeLists.txt`. The other hooks passed.
- [macOS JNI](https://github.com/apache/arrow-java/actions/runs/40071256995/job/127995936465): compilation stops in `_deps/protobuf-src/src/google/protobuf/parse_context.h` with `fatal error: 'utf8_validity.h' file not found` while building Gandiva.
These errors occur in tooling/native build paths outside this PR's two Java vector files. I have not reproduced them locally or established a dependency fix; the checks remain failed.
<sub>AI-generated CI log summary, checked against the linked job logs.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1386: Zero-pad inline views during split and transfer [arrow-java]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1387:
URL: https://github.com/apache/arrow-java/pull/1387#issuecomment-6381037468
<!-- label_helper_comment -->
Thank you for opening a pull request!
Please label the PR with one or more of:
- bug-fix
- chore
- dependencies
- documentation
- enhancement
Also, add the 'breaking-change' label if appropriate.
See [CONTRIBUTING.md](https://github.com/apache/arrow-java/blob/main/CONTRIBUTING.md) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-1386: Zero-pad inline views during split and transfer [arrow-java]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #1387:
URL: https://github.com/apache/arrow-java/pull/1387#issuecomment-6381067651
Could a maintainer add the `bug-fix` label? The format check reports a missing required label, and adding it through `gh pr edit` returns an `AddLabelsToLabelable` permission error for my account.
<sub>AI-generated coordination comment.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org