[GitHub] storm pull request #2150: STORM-2541: Fix storm-kafka-client manual subscrip...

[hmcl <gi...@git.apache.org>]

Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2150#discussion_r127769417
  
    --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicFilter.java ---
    @@ -0,0 +1,38 @@
    +/*
    + * Copyright 2017 The Apache Software Foundation.
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.storm.kafka.spout;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +import org.apache.kafka.clients.consumer.KafkaConsumer;
    +import org.apache.kafka.common.TopicPartition;
    +
    +public interface TopicFilter extends Serializable {
    +    
    +    /**
    +     * Get the Kafka TopicPartitions passed by this filter. 
    +     * @param consumer The Kafka consumer to use to read the list of existing partitions
    +     * @return The Kafka partitions passed by this filter.
    +     */
    +    List<TopicPartition> getFilteredTopicPartitions(KafkaConsumer<?, ?> consumer);
    +    
    +    /**
    +     * @return A human-readable string representing the subscribed topics.
    --- End diff --
    
    NIT: representing the topics that pass the filter


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---