You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Walter Underwood (JIRA)" <ji...@apache.org> on 2014/03/24 00:39:42 UTC
[jira] [Comment Edited] (SOLR-5228) Deprecate and
tags in schema.xml
[ https://issues.apache.org/jira/browse/SOLR-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944640#comment-13944640 ]
Walter Underwood edited comment on SOLR-5228 at 3/23/14 11:37 PM:
------------------------------------------------------------------
I certainly agree that validating XML configs against a schema is far more useful than making the parser more permissive. We should fix the problem, not the symptom.
Just this week, I found that the "required" attribute is not documented, not even the default value. That sort of stuff is easier to spot with validation, because you can check the docs against that.
And how many questions have we answered about "multivalued" vs. "multiValued"?
As we start supporting modification for config files, this gets more important. They should be validated before write.
was (Author: wunder):
I certainly agree that validating XML configs against a schema is far more useful than making the parser more permissive.
Just this week, I found that the "required" attribute is not documented, not even the default value. That sort of stuff is easier to spot with validation, because you can check the docs against that.
And how many questions have we answered about "multivalued" vs. "multiValued"?
As we start supporting modification for config files, this gets more important. They should be validated before write.
> Deprecate <fields> and <types> tags in schema.xml
> -------------------------------------------------
>
> Key: SOLR-5228
> URL: https://issues.apache.org/jira/browse/SOLR-5228
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Reporter: Hoss Man
> Assignee: Erick Erickson
> Attachments: SOLR-5228.patch, SOLR-5228.patch
>
>
> On the solr-user mailing list, Nutan recently mentioned spending days trying to track down a problem that turned out to be because he had attempted to add a {{<dynamicField .. />}} that was outside of the {{<fields>}} block in his schema.xml -- Solr was just silently ignoring it.
> We have made improvements in other areas of config validation by generating statup errors when tags/attributes are found that are not expected -- but in this case i think we should just stop expecting/requiring that the {{<fields>}} and {{<types>}} tags will be used to group these sorts of things. I think schema.xml parsing should just start ignoring them and only care about finding the {{<field>}}, {{<dynamicField>}}, and {{<fieldType>}} tags wherever they may be.
> If people want to keep using them, fine. If people want to mix fieldTypes and fields side by side (perhaps specify a fieldType, then list all the fields using it) fine. I don't see any value in forcing people to use them, but we definitely shouldn't leave things the way they are with otherwise perfectly valid field/type declarations being silently ignored.
> ---
> I'll take this on unless i see any objections.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org